From: Arnaud Giersch <arnaud.giersch@iut-bm.univ-fcomte.fr>
Date: Wed, 23 Feb 2011 22:41:19 +0000 (+0100)
Subject: Fix loba_makhoul.
X-Git-Tag: v0.1~114
X-Git-Url: https://bilbo.iut-bm.univ-fcomte.fr/and/gitweb/loba.git/commitdiff_plain/76d4afa3496d7710e7548b6bca27473db7c9308c?ds=inline;hp=--cc

Fix loba_makhoul.

Load difference (delta) must be computed before the sending loop.
---

76d4afa3496d7710e7548b6bca27473db7c9308c
diff --git a/loba_makhoul.cpp b/loba_makhoul.cpp
index bbf855f..2fca60b 100644
--- a/loba_makhoul.cpp
+++ b/loba_makhoul.cpp
@@ -2,21 +2,38 @@
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(loba);
 
+#include <algorithm>
+#include <tr1/functional>
 #include "loba_makhoul.h"
 
 void loba_makhoul::load_balance()
 {
+    using std::tr1::bind;
+    using std::tr1::placeholders::_1;
+
     pneigh_sort_by_load(std::less<double>());
 
     print_loads_p(false, xbt_log_priority_debug);
 
+    // find limit between least loaded neighbors, and more loaded ones
+    pneigh_type::iterator bound =
+        std::find_if(pneigh.begin(), pneigh.end(),
+                     bind(std::less_equal<double>(),
+                          get_load(), bind(&neighbor::get_load, _1)));
+
+    // compute load differences
+    std::vector<double> delta(bound - pneigh.begin());
+    std::transform(pneigh.begin(), bound, delta.begin(),
+                   bind(std::minus<double>(),
+                        get_load(), bind(&neighbor::get_load, _1)));
+
+    // send load...
     double alpha = 1.0 / (pneigh.size() + 1.0);
-    double delta;
     for (unsigned i = 0 ;
-         i < pneigh.size() &&
-             (delta = get_load() - pneigh[i]->get_load()) > 0.0 ;
-         ++i) {
-        send(pneigh[i], delta * alpha);
+         i < delta.size() && pneigh[i]->get_load() < get_load() ; ++i) {
+        double balance = delta[i] * alpha;
+        send(pneigh[i], balance);
+        XBT_DEBUG("sent %g to %s", balance, pneigh[i]->get_name());
     }
 }