From 124a609e80fa7bb5b7a7a698df9c6abef910d83e Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Tue, 24 May 2011 09:55:45 +0200 Subject: [PATCH 1/1] Cosmetics: rename message types, INFO -> CTRL, and LOAD -> DATA. --- communicator.cpp | 2 +- messages.cpp | 6 +++--- messages.h | 2 +- process.cpp | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/communicator.cpp b/communicator.cpp index e6a47b4..2ddea5d 100644 --- a/communicator.cpp +++ b/communicator.cpp @@ -55,7 +55,7 @@ msg_comm_t communicator::real_send(const char* dest, message* msg) XBT_DEBUG("send %s to %s", msg->to_string().c_str(), dest); m_task_t task = MSG_task_create("message", 0.0, msg->get_size(), msg); TRACE_msg_set_task_category(task, - msg->get_type() == message::LOAD ? + msg->get_type() == message::DATA ? TRACE_CAT_DATA : TRACE_CAT_CTRL); return MSG_task_isend(task, dest); } diff --git a/messages.cpp b/messages.cpp index 2eed581..fd19f6b 100644 --- a/messages.cpp +++ b/messages.cpp @@ -14,10 +14,10 @@ message::message(message_type t, double a, double c) // compute message size // arbitrary: 8 for type, and 8 for each double switch (type) { - case INFO: + case CTRL: size = opt::bookkeeping ? 24 : 16; // type + amount + (credit)? break; - case LOAD: + case DATA: size = 16 + opt::comm_cost(amount); // type + amount + data size break; default: @@ -28,7 +28,7 @@ message::message(message_type t, double a, double c) std::string message::to_string() { - static const char* str[DATA_CLOSE + 1] = { "INFO", "LOAD", + static const char* str[DATA_CLOSE + 1] = { "CTRL", "DATA", "CTRL_CLOSE", "DATA_CLOSE" }; std::ostringstream oss; oss << str[type] << ": " << amount; diff --git a/messages.h b/messages.h index 1906fdf..1886301 100644 --- a/messages.h +++ b/messages.h @@ -9,7 +9,7 @@ class message { public: - enum message_type { INFO, LOAD, CTRL_CLOSE, DATA_CLOSE }; + enum message_type { CTRL, DATA, CTRL_CLOSE, DATA_CLOSE }; message(message_type t, double a, double c = 0.0); diff --git a/process.cpp b/process.cpp index 491898d..11129e4 100644 --- a/process.cpp +++ b/process.cpp @@ -297,7 +297,7 @@ void process::ctrl_send(neighbor& nb) debt_to_send = 0.0; } if (info_to_send != prev_load_broadcast || debt_to_send > 0.0) { - message* msg = new message(message::INFO, info_to_send, debt_to_send); + message* msg = new message(message::CTRL, info_to_send, debt_to_send); add_ctrl_send_mesg(msg->get_size()); comm.ctrl_send(nb.get_ctrl_mbox(), msg); } @@ -329,7 +329,7 @@ void process::data_send(neighbor& nb) amount = std::min(load_to_send, opt::max_transfer_amount); else amount = load_to_send; - message* msg = new message(message::LOAD, amount); + message* msg = new message(message::DATA, amount); add_data_send_mesg(msg->get_size()); comm.data_send(nb.get_data_mbox(), msg); load_to_send -= amount; @@ -377,13 +377,13 @@ void process::data_receive(double timeout) void process::handle_message(message* msg, m_host_t from) { switch (msg->get_type()) { - case message::INFO: { + case message::CTRL: { neighbor* n = rev_neigh[from]; n->set_load(msg->get_amount() + n->get_to_send()); expected_load += msg->get_credit(); // may be 0.0 if !opt::bookkeeping break; } - case message::LOAD: { + case message::DATA: { double ld = msg->get_amount(); real_load += ld; if (finalizing) -- 2.39.5