From 7594a30eb5ef2059cf4a04773c7ce101378d4fca Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Thu, 1 Mar 2012 16:20:48 +0100 Subject: [PATCH] Remove useless temporary references. --- options.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/options.cpp b/options.cpp index 0ed04ac..1275bcf 100644 --- a/options.cpp +++ b/options.cpp @@ -166,25 +166,23 @@ const char* opt_helper::on_off(bool b) const char* opt_helper::descr(const char* str) { - std::string& res = descr_str; - res = str; - res.resize(DATA_DESCR_WIDTH, '.'); - return res.c_str(); + descr_str = str; + descr_str.resize(DATA_DESCR_WIDTH, '.'); + return descr_str.c_str(); } template const char* opt_helper::val_or_string(const T& val, const char* str, const T& deflt) { - std::string& res = val_or_string_str; if (val != deflt) { std::ostringstream oss; oss << val; - res = oss.str(); + val_or_string_str = oss.str(); } else { - res = str; + val_or_string_str = str; } - return res.c_str(); + return val_or_string_str.c_str(); } template -- 2.39.5