1 /* Copyright (c) 2004-2015. The SimGrid Team.
2 * All rights reserved. */
4 /* This program is free software; you can redistribute it and/or modify it
5 * under the terms of the license (GNU LGPL) which comes with this package. */
7 /* \file callbacks.h */
9 #include "xbt/sysdep.h"
11 #include "xbt/strbuff.h"
12 #include "xbt/mallocator.h"
13 #include "maxmin_private.hpp"
15 #include <stdio.h> /* sprintf */
17 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_maxmin, surf, "Logging specific to SURF (maxmin)");
19 typedef struct s_dyn_light {
23 } s_dyn_light_t, *dyn_light_t;
25 double sg_maxmin_precision = 0.00001;
26 double sg_surf_precision = 0.00001;
27 int sg_concurrency_limit= 100;
29 static void *lmm_variable_mallocator_new_f();
30 static void lmm_variable_mallocator_free_f(void *var);
31 #define lmm_variable_mallocator_reset_f ((void_f_pvoid_t)nullptr)
32 static void lmm_update_modified_set(lmm_system_t sys, lmm_constraint_t cnst);
33 static void lmm_remove_all_modified_set(lmm_system_t sys);
34 static int Global_debug_id = 1;
35 static int Global_const_debug_id = 1;
37 static void lmm_var_free(lmm_system_t sys, lmm_variable_t var);
38 static inline void lmm_cnst_free(lmm_system_t sys, lmm_constraint_t cnst);
40 static void lmm_on_disabled_var(lmm_system_t sys, lmm_constraint_t cnstr);
41 static void lmm_enable_var(lmm_system_t sys, lmm_variable_t var);
42 static int lmm_can_enable_var(lmm_variable_t var);
43 static void lmm_disable_var(lmm_system_t sys, lmm_variable_t var);
44 static int lmm_concurrency_slack(lmm_constraint_t cnstr);
45 static int lmm_cnstrs_min_concurrency_slack(lmm_variable_t var);
47 static void lmm_check_concurrency(lmm_system_t sys);
49 inline int lmm_element_concurrency(lmm_element_t elem) {
50 //Ignore element with weight less than one (e.g. cross-traffic)
51 return (elem->value>=1)?1:0;
52 //There are other alternatives, but they will change the behaviour of the model..
53 //So do not use it unless you want to make a new model.
54 //If you do, remember to change the variables concurrency share to reflect it.
55 //Potential examples are:
56 //return (elem->weight>0)?1:0;//Include element as soon as weight is non-zero
57 //return (int)ceil(elem->weight);//Include element as the rounded-up integer value of the element weight
60 inline void lmm_decrease_concurrency(lmm_element_t elem) {
61 xbt_assert(elem->constraint->concurrency_current>=lmm_element_concurrency(elem));
62 elem->constraint->concurrency_current-=lmm_element_concurrency(elem);
65 inline void lmm_increase_concurrency(lmm_element_t elem) {
66 elem->constraint->concurrency_current+= lmm_element_concurrency(elem);
68 lmm_constraint_t cnstr=elem->constraint;
70 if(cnstr->concurrency_current > cnstr->concurrency_maximum)
71 cnstr->concurrency_maximum= cnstr->concurrency_current;
73 xbt_assert(cnstr->concurrency_limit<0 || cnstr->concurrency_current<=cnstr->concurrency_limit,
74 "Concurrency limit overflow!");
77 lmm_system_t lmm_system_new(int selective_update)
79 lmm_system_t l = nullptr;
81 s_lmm_constraint_t cnst;
83 l = xbt_new0(s_lmm_system_t, 1);
86 l->selective_update_active = selective_update;
87 l->visited_counter = 1;
89 XBT_DEBUG("Setting selective_update_active flag to %d", l->selective_update_active);
91 xbt_swag_init(&(l->variable_set), xbt_swag_offset(var, variable_set_hookup));
92 xbt_swag_init(&(l->constraint_set), xbt_swag_offset(cnst, constraint_set_hookup));
94 xbt_swag_init(&(l->active_constraint_set), xbt_swag_offset(cnst, active_constraint_set_hookup));
96 xbt_swag_init(&(l->modified_constraint_set), xbt_swag_offset(cnst, modified_constraint_set_hookup));
97 xbt_swag_init(&(l->saturated_variable_set), xbt_swag_offset(var, saturated_variable_set_hookup));
98 xbt_swag_init(&(l->saturated_constraint_set), xbt_swag_offset(cnst, saturated_constraint_set_hookup));
100 l->variable_mallocator = xbt_mallocator_new(65536,
101 lmm_variable_mallocator_new_f,
102 lmm_variable_mallocator_free_f,
103 lmm_variable_mallocator_reset_f);
108 void lmm_system_free(lmm_system_t sys)
110 lmm_variable_t var = nullptr;
111 lmm_constraint_t cnst = nullptr;
116 while ((var = (lmm_variable_t) extract_variable(sys))) {
117 XBT_WARN("Variable %d still in system when freing it: this may be a bug", var->id_int);
118 lmm_var_free(sys, var);
120 while ((cnst = (lmm_constraint_t) extract_constraint(sys)))
121 lmm_cnst_free(sys, cnst);
123 xbt_mallocator_free(sys->variable_mallocator);
127 static inline void lmm_variable_remove(lmm_system_t sys, lmm_variable_t var)
132 lmm_element_t elem = nullptr;
134 XBT_IN("(sys=%p, var=%p)", sys, var);
137 //TODOLATER Can do better than that by leaving only the variable in only one enabled_element_set, call
138 //lmm_update_modified_set, and then remove it..
139 if(var->cnsts_number)
140 lmm_update_modified_set(sys, var->cnsts[0].constraint);
142 for (i = 0; i < var->cnsts_number; i++) {
143 elem = &var->cnsts[i];
145 lmm_decrease_concurrency(elem);
146 xbt_swag_remove(elem, &(elem->constraint->enabled_element_set));
147 xbt_swag_remove(elem, &(elem->constraint->disabled_element_set));
148 xbt_swag_remove(elem, &(elem->constraint->active_element_set));
149 nelements=xbt_swag_size(&(elem->constraint->enabled_element_set)) +
150 xbt_swag_size(&(elem->constraint->disabled_element_set));
152 make_constraint_inactive(sys, elem->constraint);
154 lmm_on_disabled_var(sys,elem->constraint);
157 //Check if we can enable new variables going through the constraints where var was.
158 //Do it after removing all elements, so he first disabled variables get priority over those with smaller requirement
159 for (i = 0; i < var->cnsts_number; i++) {
160 elem = &var->cnsts[i];
161 if(xbt_swag_size(&(elem->constraint->disabled_element_set)))
162 lmm_on_disabled_var(sys,elem->constraint);
165 var->cnsts_number = 0;
167 lmm_check_concurrency(sys);
172 static void lmm_var_free(lmm_system_t sys, lmm_variable_t var)
174 lmm_variable_remove(sys, var);
175 xbt_mallocator_release(sys->variable_mallocator, var);
178 static inline void lmm_cnst_free(lmm_system_t sys, lmm_constraint_t cnst)
180 make_constraint_inactive(sys, cnst);
184 lmm_constraint_t lmm_constraint_new(lmm_system_t sys, void *id, double bound_value)
186 lmm_constraint_t cnst = nullptr;
187 s_lmm_element_t elem;
189 cnst = xbt_new0(s_lmm_constraint_t, 1);
191 cnst->id_int = Global_const_debug_id++;
192 xbt_swag_init(&(cnst->enabled_element_set), xbt_swag_offset(elem, enabled_element_set_hookup));
193 xbt_swag_init(&(cnst->disabled_element_set), xbt_swag_offset(elem, disabled_element_set_hookup));
194 xbt_swag_init(&(cnst->active_element_set), xbt_swag_offset(elem, active_element_set_hookup));
196 cnst->bound = bound_value;
197 cnst->concurrency_maximum=0;
198 cnst->concurrency_current=0;
199 cnst->concurrency_limit=sg_concurrency_limit;
201 cnst->sharing_policy = 1; /* FIXME: don't hardcode the value */
202 insert_constraint(sys, cnst);
207 int lmm_constraint_concurrency_limit_get(lmm_constraint_t cnst)
209 return cnst->concurrency_limit;
212 void lmm_constraint_concurrency_limit_set(lmm_constraint_t cnst, int concurrency_limit)
214 xbt_assert(concurrency_limit<0 || cnst->concurrency_maximum<=concurrency_limit,
215 "New concurrency limit should be larger than observed concurrency maximum. Maybe you want to call"
216 " lmm_constraint_concurrency_maximum_reset() to reset the maximum?");
217 cnst->concurrency_limit = concurrency_limit;
220 void lmm_constraint_concurrency_maximum_reset(lmm_constraint_t cnst)
222 cnst->concurrency_maximum = 0;
225 int lmm_constraint_concurrency_maximum_get(lmm_constraint_t cnst)
227 xbt_assert(cnst->concurrency_limit<0 || cnst->concurrency_maximum<=cnst->concurrency_limit,
228 "Very bad: maximum observed concurrency is higher than limit. This is a bug of SURF, please report it.");
229 return cnst->concurrency_maximum;
232 void lmm_constraint_shared(lmm_constraint_t cnst)
234 cnst->sharing_policy = 0;
237 /** Return true if the constraint is shared, and false if it's FATPIPE */
238 int lmm_constraint_sharing_policy(lmm_constraint_t cnst)
240 return (cnst->sharing_policy);
243 /* @brief Remove a constraint
244 * Currently this is dead code, but it is exposed in maxmin.h
245 * Apparently, this call was designed assuming that constraint would no more have elements in it.
246 * If not the case, assertion will fail, and you need to add calls e.g. to lmm_shrink before effectively removing it.
248 inline void lmm_constraint_free(lmm_system_t sys,lmm_constraint_t cnst)
250 xbt_assert(!xbt_swag_size(&(cnst->active_element_set)),"Removing constraint but it still has active elements");
251 xbt_assert(!xbt_swag_size(&(cnst->enabled_element_set)),"Removing constraint but it still has enabled elements");
252 xbt_assert(!xbt_swag_size(&(cnst->disabled_element_set)),"Removing constraint but it still has disabled elements");
253 remove_constraint(sys, cnst);
254 lmm_cnst_free(sys, cnst);
257 static void *lmm_variable_mallocator_new_f()
259 lmm_variable_t var = xbt_new(s_lmm_variable_t, 1);
260 var->cnsts = nullptr; /* will be created by realloc */
264 static void lmm_variable_mallocator_free_f(void *var)
266 xbt_free(((lmm_variable_t) var)->cnsts);
270 lmm_variable_t lmm_variable_new(lmm_system_t sys, void *id, double weight, double bound, int number_of_constraints)
272 lmm_variable_t var = nullptr;
275 XBT_IN("(sys=%p, id=%p, weight=%f, bound=%f, num_cons =%d)", sys, id, weight, bound, number_of_constraints);
277 var = (lmm_variable_t) xbt_mallocator_get(sys->variable_mallocator);
279 var->id_int = Global_debug_id++;
280 var->cnsts = (s_lmm_element_t *) xbt_realloc(var->cnsts, number_of_constraints * sizeof(s_lmm_element_t));
281 for (i = 0; i < number_of_constraints; i++) {
282 var->cnsts[i].enabled_element_set_hookup.next = nullptr;
283 var->cnsts[i].enabled_element_set_hookup.prev = nullptr;
284 var->cnsts[i].disabled_element_set_hookup.next = nullptr;
285 var->cnsts[i].disabled_element_set_hookup.prev = nullptr;
286 var->cnsts[i].active_element_set_hookup.next = nullptr;
287 var->cnsts[i].active_element_set_hookup.prev = nullptr;
288 var->cnsts[i].constraint = nullptr;
289 var->cnsts[i].variable = nullptr;
290 var->cnsts[i].value = 0.0;
292 var->cnsts_size = number_of_constraints;
293 var->cnsts_number = 0;
294 var->weight = weight;
295 var->staged_weight = 0.0;
297 var->concurrency_share = 1;
299 var->visited = sys->visited_counter - 1;
302 var->func_f = func_f_def;
303 var->func_fp = func_fp_def;
304 var->func_fpi = func_fpi_def;
306 var->variable_set_hookup.next = nullptr;
307 var->variable_set_hookup.prev = nullptr;
308 var->saturated_variable_set_hookup.next = nullptr;
309 var->saturated_variable_set_hookup.prev = nullptr;
312 xbt_swag_insert_at_head(var, &(sys->variable_set));
314 xbt_swag_insert_at_tail(var, &(sys->variable_set));
316 XBT_OUT(" returns %p", var);
320 void lmm_variable_free(lmm_system_t sys, lmm_variable_t var)
322 remove_variable(sys, var);
323 lmm_var_free(sys, var);
326 double lmm_variable_getvalue(lmm_variable_t var)
331 void lmm_variable_concurrency_share_set(lmm_variable_t var, short int concurrency_share)
333 var->concurrency_share=concurrency_share;
336 double lmm_variable_getbound(lmm_variable_t var)
341 void lmm_shrink(lmm_system_t sys, lmm_constraint_t cnst, lmm_variable_t var)
343 lmm_element_t elem = nullptr;
347 for (i = 0; i < var->cnsts_number; i++) {
348 elem = &(var->cnsts[i]);
349 if (elem->constraint == cnst) {
356 XBT_DEBUG("cnst %p is not found in var %p", cnst, var);
362 XBT_DEBUG("remove elem(value %f, cnst %p, var %p) in var %p", elem->value, elem->constraint, elem->variable, var);
364 /* We are going to change the constraint object and the variable object.
365 * Propagate this change to other objects. Calling here before removing variable from not active elements
366 * (inactive elements are not visited)
368 lmm_update_modified_set(sys, cnst);
369 //Useful in case var was already removed from the constraint
370 lmm_update_modified_set(sys, var->cnsts[0].constraint); // will look up enabled_element_set of this constraint, and
371 //then each var in the enabled_element_set, and each var->cnsts[i].
373 if(xbt_swag_remove(elem, &(elem->constraint->enabled_element_set)))
374 lmm_decrease_concurrency(elem);
376 xbt_swag_remove(elem, &(elem->constraint->active_element_set));
377 elem->constraint = nullptr;
378 elem->variable = nullptr;
381 var->cnsts_number -= 1;
383 //No variable in this constraint -> make it inactive
384 if (xbt_swag_size(&(cnst->enabled_element_set))+xbt_swag_size(&(cnst->disabled_element_set)) == 0)
385 make_constraint_inactive(sys, cnst);
387 //Check maxconcurrency to see if we can enable new variables
388 lmm_on_disabled_var(sys,elem->constraint);
391 lmm_check_concurrency(sys);
394 void lmm_expand(lmm_system_t sys, lmm_constraint_t cnst, lmm_variable_t var, double value)
396 lmm_element_t elem = nullptr;
402 //Check if this variable already has an active element in this constraint
403 //If it does, substract it from the required slack
405 if(var->concurrency_share>1){
406 for( i=0; i<var->cnsts_number;i++){
407 if(var->cnsts[i].constraint==cnst &&
408 xbt_swag_belongs(&var->cnsts[i],&(var->cnsts[i].constraint->enabled_element_set)))
409 current_share+=lmm_element_concurrency(&(var->cnsts[i]));
413 //Check if we need to disable the variable
414 if(var->weight>0 && var->concurrency_share-current_share>lmm_concurrency_slack(cnst)) {
416 lmm_disable_var(sys,var);
417 for (i = 0; i < var->cnsts_number; i++)
418 lmm_on_disabled_var(sys,var->cnsts[i].constraint);
420 var->staged_weight=weight;
421 xbt_assert(!var->weight);
424 xbt_assert(var->cnsts_number < var->cnsts_size, "Too much constraints");
426 elem = &(var->cnsts[var->cnsts_number++]);
429 elem->constraint = cnst;
430 elem->variable = var;
433 xbt_swag_insert_at_head(elem, &(elem->constraint->enabled_element_set));
434 lmm_increase_concurrency(elem);
436 xbt_swag_insert_at_tail(elem, &(elem->constraint->disabled_element_set));
438 if(!sys->selective_update_active) {
439 make_constraint_active(sys, cnst);
440 } else if(elem->value>0 || var->weight >0) {
441 make_constraint_active(sys, cnst);
442 lmm_update_modified_set(sys, cnst);
443 //TODOLATER: Why do we need this second call?
444 if (var->cnsts_number > 1)
445 lmm_update_modified_set(sys, var->cnsts[0].constraint);
448 lmm_check_concurrency(sys);
451 void lmm_expand_add(lmm_system_t sys, lmm_constraint_t cnst, lmm_variable_t var, double value)
457 lmm_check_concurrency(sys);
459 //BEWARE: In case you have multiple elements in one constraint, this will always add value to the first element.
460 for (i = 0; i < var->cnsts_number; i++)
461 if (var->cnsts[i].constraint == cnst)
464 if (i < var->cnsts_number) {
466 lmm_decrease_concurrency(&var->cnsts[i]);
468 if (cnst->sharing_policy)
469 var->cnsts[i].value += value;
471 var->cnsts[i].value = MAX(var->cnsts[i].value, value);
473 //We need to check that increasing value of the element does not cross the concurrency limit
475 if(lmm_concurrency_slack(cnst)<lmm_element_concurrency(&var->cnsts[i])){
477 lmm_disable_var(sys,var);
478 for (j = 0; j < var->cnsts_number; j++)
479 lmm_on_disabled_var(sys,var->cnsts[j].constraint);
480 var->staged_weight=weight;
481 xbt_assert(!var->weight);
483 lmm_increase_concurrency(&var->cnsts[i]);
485 lmm_update_modified_set(sys, cnst);
487 lmm_expand(sys, cnst, var, value);
489 lmm_check_concurrency(sys);
492 lmm_constraint_t lmm_get_cnst_from_var(lmm_system_t /*sys*/, lmm_variable_t var, int num)
494 if (num < var->cnsts_number)
495 return (var->cnsts[num].constraint);
500 double lmm_get_cnst_weight_from_var(lmm_system_t /*sys*/, lmm_variable_t var, int num)
502 if (num < var->cnsts_number)
503 return (var->cnsts[num].value);
508 int lmm_get_number_of_cnst_from_var(lmm_system_t /*sys*/, lmm_variable_t var)
510 return (var->cnsts_number);
513 lmm_variable_t lmm_get_var_from_cnst(lmm_system_t /*sys*/, lmm_constraint_t cnst, lmm_element_t * elem)
516 // That is the first call, pick the first element among enabled_element_set (or disabled_element_set if
517 // enabled_element_set is empty)
518 *elem = (lmm_element_t) xbt_swag_getFirst(&(cnst->enabled_element_set));
520 *elem = (lmm_element_t) xbt_swag_getFirst(&(cnst->disabled_element_set));
522 //elem is not null, so we carry on
523 if(xbt_swag_belongs(*elem,&(cnst->enabled_element_set))){
524 //Look at enabled_element_set, and jump to disabled_element_set when finished
525 *elem = (lmm_element_t) xbt_swag_getNext(*elem, cnst->enabled_element_set.offset);
527 *elem = (lmm_element_t) xbt_swag_getFirst(&(cnst->disabled_element_set));
529 *elem = (lmm_element_t) xbt_swag_getNext(*elem, cnst->disabled_element_set.offset);
533 return (*elem)->variable;
538 //if we modify the swag between calls, normal version may loop forever
539 //this safe version ensures that we browse the swag elements only once
540 lmm_variable_t lmm_get_var_from_cnst_safe(lmm_system_t /*sys*/, lmm_constraint_t cnst, lmm_element_t * elem,
541 lmm_element_t * nextelem, int * numelem)
544 *elem = (lmm_element_t) xbt_swag_getFirst(&(cnst->enabled_element_set));
545 *numelem = xbt_swag_size(&(cnst->enabled_element_set))+xbt_swag_size(&(cnst->disabled_element_set))-1;
547 *elem = (lmm_element_t) xbt_swag_getFirst(&(cnst->disabled_element_set));
556 //elem is not null, so we carry on
557 if(xbt_swag_belongs(*elem,&(cnst->enabled_element_set))){
558 //Look at enabled_element_set, and jump to disabled_element_set when finished
559 *nextelem = (lmm_element_t) xbt_swag_getNext(*elem, cnst->enabled_element_set.offset);
561 *nextelem = (lmm_element_t) xbt_swag_getFirst(&(cnst->disabled_element_set));
563 *nextelem = (lmm_element_t) xbt_swag_getNext(*elem, cnst->disabled_element_set.offset);
565 return (*elem)->variable;
570 void *lmm_constraint_id(lmm_constraint_t cnst)
575 void *lmm_variable_id(lmm_variable_t var)
580 static inline void saturated_constraint_set_update(double usage, int cnst_light_num,
581 dyn_light_t saturated_constraint_set, double *min_usage)
583 xbt_assert(usage > 0,"Impossible");
585 if (*min_usage < 0 || *min_usage > usage) {
587 XBT_HERE(" min_usage=%f (cnst->remaining / cnst->usage =%f)", *min_usage, usage);
588 saturated_constraint_set->data[0] = cnst_light_num;
589 saturated_constraint_set->pos = 1;
590 } else if (*min_usage == usage) {
591 if(saturated_constraint_set->pos == saturated_constraint_set->size) { // realloc the size
592 saturated_constraint_set->size *= 2;
593 saturated_constraint_set->data =
594 (int*) xbt_realloc(saturated_constraint_set->data, (saturated_constraint_set->size) * sizeof(int));
596 saturated_constraint_set->data[saturated_constraint_set->pos] = cnst_light_num;
597 saturated_constraint_set->pos++;
601 static inline void saturated_variable_set_update(s_lmm_constraint_light_t *cnst_light_tab,
602 dyn_light_t saturated_constraint_set, lmm_system_t sys)
604 /* Add active variables (i.e. variables that need to be set) from the set of constraints to saturate (cnst_light_tab)*/
605 lmm_constraint_light_t cnst = nullptr;
607 lmm_element_t elem = nullptr;
608 xbt_swag_t elem_list = nullptr;
610 for(i = 0; i< saturated_constraint_set->pos; i++){
611 cnst = &cnst_light_tab[saturated_constraint_set->data[i]];
612 elem_list = &(cnst->cnst->active_element_set);
613 xbt_swag_foreach(_elem, elem_list) {
614 elem = (lmm_element_t)_elem;
615 //Visiting active_element_set, so, by construction, should never get a zero weight, correct?
616 xbt_assert(elem->variable->weight > 0);
617 if ((elem->value > 0))
618 xbt_swag_insert(elem->variable, &(sys->saturated_variable_set));
623 void lmm_print(lmm_system_t sys)
625 void *_cnst, *_elem, *_var;
626 lmm_constraint_t cnst = nullptr;
627 lmm_element_t elem = nullptr;
628 lmm_variable_t var = nullptr;
629 xbt_swag_t cnst_list = nullptr;
630 xbt_swag_t var_list = nullptr;
631 xbt_swag_t elem_list = nullptr;
632 xbt_strbuff_t buf = xbt_strbuff_new();
635 /* Printing Objective */
636 var_list = &(sys->variable_set);
637 xbt_strbuff_append(buf, "MAX-MIN ( ");
638 xbt_swag_foreach(_var, var_list) {
639 var = (lmm_variable_t)_var;
640 xbt_strbuff_printf(buf, "'%d'(%f) ", var->id_int, var->weight);
642 xbt_strbuff_append(buf, ")");
643 XBT_DEBUG("%20s", buf->data);
644 xbt_strbuff_clear(buf);
646 XBT_DEBUG("Constraints");
647 /* Printing Constraints */
648 cnst_list = &(sys->active_constraint_set);
649 xbt_swag_foreach(_cnst, cnst_list) {
650 cnst = (lmm_constraint_t)_cnst;
652 //Show the enabled variables
653 elem_list = &(cnst->enabled_element_set);
654 xbt_strbuff_append(buf, "\t");
655 xbt_strbuff_printf(buf, "%s(", (cnst->sharing_policy)?"":"max");
656 xbt_swag_foreach(_elem, elem_list) {
657 elem = (lmm_element_t)_elem;
658 xbt_strbuff_printf(buf, "%f.'%d'(%f) %s ", elem->value,
659 elem->variable->id_int, elem->variable->value,(cnst->sharing_policy)?"+":",");
660 if(cnst->sharing_policy)
661 sum += elem->value * elem->variable->value;
663 sum = MAX(sum,elem->value * elem->variable->value);
665 //TODO: Adding disabled elements only for test compatibility, but do we really want them to be printed?
666 elem_list = &(cnst->disabled_element_set);
667 xbt_swag_foreach(_elem, elem_list) {
668 elem = (lmm_element_t)_elem;
669 xbt_strbuff_printf(buf, "%f.'%d'(%f) %s ", elem->value,
670 elem->variable->id_int, elem->variable->value,(cnst->sharing_policy)?"+":",");
671 if(cnst->sharing_policy)
672 sum += elem->value * elem->variable->value;
674 sum = MAX(sum,elem->value * elem->variable->value);
677 xbt_strbuff_printf(buf, "0) <= %f ('%d')", cnst->bound, cnst->id_int);
679 if (!cnst->sharing_policy) {
680 xbt_strbuff_printf(buf, " [MAX-Constraint]");
682 XBT_DEBUG("%s", buf->data);
683 xbt_strbuff_clear(buf);
684 xbt_assert(!double_positive(sum - cnst->bound, cnst->bound*sg_maxmin_precision),
685 "Incorrect value (%f is not smaller than %f): %g", sum, cnst->bound, sum - cnst->bound);
686 //if(double_positive(sum - cnst->bound, cnst->bound*sg_maxmin_precision))
687 //XBT_ERROR("Incorrect value (%f is not smaller than %f): %g",sum, cnst->bound, sum - cnst->bound);
690 XBT_DEBUG("Variables");
691 /* Printing Result */
692 xbt_swag_foreach(_var, var_list) {
693 var = (lmm_variable_t)_var;
694 if (var->bound > 0) {
695 XBT_DEBUG("'%d'(%f) : %f (<=%f)", var->id_int, var->weight, var->value, var->bound);
696 xbt_assert(!double_positive(var->value - var->bound, var->bound*sg_maxmin_precision),
697 "Incorrect value (%f is not smaller than %f", var->value, var->bound);
699 XBT_DEBUG("'%d'(%f) : %f", var->id_int, var->weight, var->value);
703 xbt_strbuff_free(buf);
706 void lmm_solve(lmm_system_t sys)
708 void *_var, *_cnst, *_cnst_next, *_elem;
709 lmm_variable_t var = nullptr;
710 lmm_constraint_t cnst = nullptr;
711 lmm_element_t elem = nullptr;
712 xbt_swag_t cnst_list = nullptr;
713 xbt_swag_t var_list = nullptr;
714 xbt_swag_t elem_list = nullptr;
715 double min_usage = -1;
716 double min_bound = -1;
718 if (!(sys->modified))
721 XBT_IN("(sys=%p)", sys);
723 /* Compute Usage and store the variables that reach the maximum. If selective_update_active is true, only constraints
724 * that changed are considered. Otherwise all constraints with active actions are considered.
726 cnst_list = sys->selective_update_active ? &(sys->modified_constraint_set) : &(sys->active_constraint_set);
728 XBT_DEBUG("Active constraints : %d", xbt_swag_size(cnst_list));
729 /* Init: Only modified code portions: reset the value of active variables */
730 xbt_swag_foreach(_cnst, cnst_list) {
731 cnst = (lmm_constraint_t)_cnst;
732 elem_list = &(cnst->enabled_element_set);
733 //XBT_DEBUG("Variable set : %d", xbt_swag_size(elem_list));
734 xbt_swag_foreach(_elem, elem_list) {
735 var = ((lmm_element_t)_elem)->variable;
736 xbt_assert(var->weight > 0.0);
741 s_lmm_constraint_light_t *cnst_light_tab =
742 (s_lmm_constraint_light_t *)xbt_malloc0(xbt_swag_size(cnst_list)*sizeof(s_lmm_constraint_light_t));
743 int cnst_light_num = 0;
744 dyn_light_t saturated_constraint_set = xbt_new0(s_dyn_light_t,1);
745 saturated_constraint_set->size = 5;
746 saturated_constraint_set->data = xbt_new0(int, saturated_constraint_set->size);
748 xbt_swag_foreach_safe(_cnst, _cnst_next, cnst_list) {
749 cnst = (lmm_constraint_t)_cnst;
750 /* INIT: Collect constraints that actually need to be saturated (i.e remaining and usage are strictly positive)
751 * into cnst_light_tab. */
752 cnst->remaining = cnst->bound;
753 if (!double_positive(cnst->remaining, cnst->bound*sg_maxmin_precision))
756 elem_list = &(cnst->enabled_element_set);
757 xbt_swag_foreach(_elem, elem_list) {
758 elem = (lmm_element_t)_elem;
759 xbt_assert(elem->variable->weight > 0);
760 if ((elem->value > 0)) {
761 if (cnst->sharing_policy)
762 cnst->usage += elem->value / elem->variable->weight;
763 else if (cnst->usage < elem->value / elem->variable->weight)
764 cnst->usage = elem->value / elem->variable->weight;
766 make_elem_active(elem);
767 simgrid::surf::Action *action = static_cast<simgrid::surf::Action*>(elem->variable->id);
768 if (sys->keep_track && !action->is_linked())
769 sys->keep_track->push_back(*action);
772 XBT_DEBUG("Constraint '%d' usage: %f remaining: %f concurrency: %i<=%i<=%i", cnst->id_int, cnst->usage,
773 cnst->remaining,cnst->concurrency_current,cnst->concurrency_maximum,cnst->concurrency_limit);
774 /* Saturated constraints update */
776 if(cnst->usage > 0) {
777 cnst_light_tab[cnst_light_num].cnst = cnst;
778 cnst->cnst_light = &(cnst_light_tab[cnst_light_num]);
779 cnst_light_tab[cnst_light_num].remaining_over_usage = cnst->remaining / cnst->usage;
780 saturated_constraint_set_update(cnst_light_tab[cnst_light_num].remaining_over_usage,
781 cnst_light_num, saturated_constraint_set, &min_usage);
782 xbt_assert(cnst->active_element_set.count>0, "There is no sense adding a constraint that has no active element!");
787 saturated_variable_set_update( cnst_light_tab, saturated_constraint_set, sys);
789 /* Saturated variables update */
791 /* Fix the variables that have to be */
792 var_list = &(sys->saturated_variable_set);
794 xbt_swag_foreach(_var, var_list) {
795 var = (lmm_variable_t)_var;
796 if (var->weight <= 0.0)
798 /* First check if some of these variables could reach their upper bound and update min_bound accordingly. */
800 ("var=%d, var->bound=%f, var->weight=%f, min_usage=%f, var->bound*var->weight=%f",
801 var->id_int, var->bound, var->weight, min_usage, var->bound * var->weight);
802 if ((var->bound > 0) && (var->bound * var->weight < min_usage)) {
804 min_bound = var->bound*var->weight;
806 min_bound = MIN(min_bound, (var->bound*var->weight));
807 XBT_DEBUG("Updated min_bound=%f", min_bound);
811 while ((var = (lmm_variable_t)xbt_swag_getFirst(var_list))) {
815 //If no variable could reach its bound, deal iteratively the constraints usage ( at worst one constraint is
816 // saturated at each cycle)
817 var->value = min_usage / var->weight;
818 // XBT_DEBUG("Setting %p (%d) value to %f\n", var, var->id_int, var->value);
819 XBT_DEBUG("Setting var (%d) value to %f\n", var->id_int, var->value);
821 //If there exist a variable that can reach its bound, only update it (and other with the same bound) for now.
822 if (double_equals(min_bound, var->bound*var->weight, sg_maxmin_precision)){
823 var->value = var->bound;
824 XBT_DEBUG("Setting %p (%d) value to %f\n", var, var->id_int, var->value);
826 // Variables which bound is different are not considered for this cycle, but they will be afterwards.
827 XBT_DEBUG("Do not consider %p (%d) \n", var, var->id_int);
828 xbt_swag_remove(var, var_list);
832 XBT_DEBUG("Min usage: %f, Var(%d)->weight: %f, Var(%d)->value: %f ",
833 min_usage, var->id_int, var->weight, var->id_int, var->value);
835 /* Update the usage of contraints where this variable is involved */
836 for (i = 0; i < var->cnsts_number; i++) {
837 elem = &var->cnsts[i];
838 cnst = elem->constraint;
839 if (cnst->sharing_policy) {
840 //Remember: shared constraints require that sum(elem->value * var->value) < cnst->bound
841 double_update(&(cnst->remaining), elem->value * var->value, cnst->bound*sg_maxmin_precision);
842 double_update(&(cnst->usage), elem->value / var->weight, sg_maxmin_precision);
843 //If the constraint is saturated, remove it from the set of active constraints (light_tab)
844 if(!double_positive(cnst->usage,sg_maxmin_precision) ||
845 !double_positive(cnst->remaining,cnst->bound*sg_maxmin_precision)) {
846 if (cnst->cnst_light) {
847 int index = (cnst->cnst_light-cnst_light_tab);
848 XBT_DEBUG("index: %d \t cnst_light_num: %d \t || usage: %f remaining: %f bound: %f ",
849 index,cnst_light_num, cnst->usage, cnst->remaining, cnst->bound);
850 //XBT_DEBUG("index: %d \t cnst_light_num: %d \t || \t cnst: %p \t cnst->cnst_light: %p "
851 // "\t cnst_light_tab: %p usage: %f remaining: %f bound: %f ", index,cnst_light_num,
852 // cnst, cnst->cnst_light, cnst_light_tab, cnst->usage, cnst->remaining, cnst->bound);
853 cnst_light_tab[index]=cnst_light_tab[cnst_light_num-1];
854 cnst_light_tab[index].cnst->cnst_light = &cnst_light_tab[index];
856 cnst->cnst_light = nullptr;
859 cnst->cnst_light->remaining_over_usage = cnst->remaining / cnst->usage;
861 make_elem_inactive(elem);
863 //Remember: non-shared constraints only require that max(elem->value * var->value) < cnst->bound
865 make_elem_inactive(elem);
866 elem_list = &(cnst->enabled_element_set);
867 xbt_swag_foreach(_elem, elem_list) {
868 elem = (lmm_element_t)_elem;
869 xbt_assert(elem->variable->weight > 0);
870 if (elem->variable->value > 0) continue;
872 cnst->usage = MAX(cnst->usage, elem->value / elem->variable->weight);
874 //If the constraint is saturated, remove it from the set of active constraints (light_tab)
875 if(!double_positive(cnst->usage,sg_maxmin_precision) ||
876 !double_positive(cnst->remaining,cnst->bound*sg_maxmin_precision)) {
877 if(cnst->cnst_light) {
878 int index = (cnst->cnst_light-cnst_light_tab);
879 XBT_DEBUG("index: %d \t cnst_light_num: %d \t || \t cnst: %p \t cnst->cnst_light: %p "
880 "\t cnst_light_tab: %p usage: %f remaining: %f bound: %f ", index,cnst_light_num, cnst,
881 cnst->cnst_light, cnst_light_tab, cnst->usage, cnst->remaining, cnst->bound);
882 cnst_light_tab[index]=cnst_light_tab[cnst_light_num-1];
883 cnst_light_tab[index].cnst->cnst_light = &cnst_light_tab[index];
885 cnst->cnst_light = nullptr;
888 cnst->cnst_light->remaining_over_usage = cnst->remaining / cnst->usage;
889 xbt_assert(cnst->active_element_set.count>0, "Should not keep a maximum constraint that has no active"
890 " element! You want to check the maxmin precision and possible rounding effects." );
894 xbt_swag_remove(var, var_list);
897 /* Find out which variables reach the maximum */
900 saturated_constraint_set->pos = 0;
902 for(pos=0; pos<cnst_light_num; pos++){
903 xbt_assert(cnst_light_tab[pos].cnst->active_element_set.count>0, "Cannot saturate more a constraint that has"
904 " no active element! You may want to change the maxmin precision (--cfg=maxmin/precision:<new_value>)"
905 " because of possible rounding effects.\n\tFor the record, the usage of this constraint is %g while "
906 "the maxmin precision to which it is compared is %g.\n\tThe usage of the previous constraint is %g.",
907 cnst_light_tab[pos].cnst->usage, sg_maxmin_precision, cnst_light_tab[pos-1].cnst->usage);
908 saturated_constraint_set_update(cnst_light_tab[pos].remaining_over_usage, pos, saturated_constraint_set,
912 saturated_variable_set_update(cnst_light_tab, saturated_constraint_set, sys);
914 } while (cnst_light_num > 0);
917 if (sys->selective_update_active)
918 lmm_remove_all_modified_set(sys);
920 if (XBT_LOG_ISENABLED(surf_maxmin, xbt_log_priority_debug)) {
924 lmm_check_concurrency(sys);
926 xbt_free(saturated_constraint_set->data);
927 xbt_free(saturated_constraint_set);
928 xbt_free(cnst_light_tab);
932 /** \brief Attribute the value bound to var->bound.
934 * \param sys the lmm_system_t
935 * \param var the lmm_variable_t
936 * \param bound the new bound to associate with var
938 * Makes var->bound equal to bound. Whenever this function is called a change is signed in the system. To
939 * avoid false system changing detection it is a good idea to test (bound != 0) before calling it.
941 void lmm_update_variable_bound(lmm_system_t sys, lmm_variable_t var, double bound)
946 if (var->cnsts_number)
947 lmm_update_modified_set(sys, var->cnsts[0].constraint);
950 int lmm_concurrency_slack(lmm_constraint_t cnstr){
951 //FIXME MARTIN: Replace by infinite value std::numeric_limits<int>::(max)(), or something better within Simgrid?
952 if(cnstr->concurrency_limit<0)
955 return cnstr->concurrency_limit - cnstr->concurrency_current;
958 /** \brief Measure the minimum concurrency slack across all constraints where the given var is involved */
959 int lmm_cnstrs_min_concurrency_slack(lmm_variable_t var){
961 //FIXME MARTIN: Replace by infinite value std::numeric_limits<int>::(max)(), or something better within Simgrid?
962 int slack,minslack=666;
963 for (i = 0; i < var->cnsts_number; i++) {
964 slack=lmm_concurrency_slack(var->cnsts[i].constraint);
966 //This is only an optimization, to avoid looking at more constraints when slack is already zero
967 //Disable it when debugging to let lmm_concurrency_slack catch nasty things
968 if(!slack && !XBT_LOG_ISENABLED(surf_maxmin, xbt_log_priority_debug))
978 /* /Check if a variable can be enabled
980 * Make sure to set staged_weight before, if your intent is only to check concurrency
982 int lmm_can_enable_var(lmm_variable_t var){
983 return var->staged_weight>0 && lmm_cnstrs_min_concurrency_slack(var)>=var->concurrency_share;
986 //Small remark: In this implementation of lmm_enable_var and lmm_disable_var, we will meet multiple times with var when
987 // running lmm_update_modified_set.
988 //A priori not a big performance issue, but we might do better by calling lmm_update_modified_set within the for loops
989 // (after doing the first for enabling==1, and before doing the last for disabling==1)
990 void lmm_enable_var(lmm_system_t sys, lmm_variable_t var){
994 xbt_assert(lmm_can_enable_var(var));
996 var->weight = var->staged_weight;
997 var->staged_weight = 0;
999 //Enabling the variable, move to var to list head. Subtility is: here, we need to call lmm_update_modified_set AFTER
1000 // moving at least one element of var.
1002 xbt_swag_remove(var, &(sys->variable_set));
1003 xbt_swag_insert_at_head(var, &(sys->variable_set));
1004 for (i = 0; i < var->cnsts_number; i++) {
1005 elem = &var->cnsts[i];
1006 xbt_swag_remove(elem, &(elem->constraint->disabled_element_set));
1007 xbt_swag_insert_at_head(elem, &(elem->constraint->enabled_element_set));
1008 lmm_increase_concurrency(elem);
1010 if (var->cnsts_number)
1011 lmm_update_modified_set(sys, var->cnsts[0].constraint);
1013 //When used within lmm_on_disabled_var, we would get an assertion fail, because transiently there can be variables
1014 // that are staged and could be activated.
1015 //Anyway, caller functions all call lmm_check_concurrency() in the end.
1016 // lmm_check_concurrency(sys);
1019 void lmm_disable_var(lmm_system_t sys, lmm_variable_t var){
1023 xbt_assert(!var->staged_weight,"Staged weight should have been cleared");
1024 //Disabling the variable, move to var to list tail. Subtility is: here, we need to call lmm_update_modified_set BEFORE
1025 //moving the last element of var.
1026 xbt_swag_remove(var, &(sys->variable_set));
1027 xbt_swag_insert_at_tail(var, &(sys->variable_set));
1028 if (var->cnsts_number)
1029 lmm_update_modified_set(sys, var->cnsts[0].constraint);
1030 for (i = 0; i < var->cnsts_number; i++) {
1031 elem = &var->cnsts[i];
1032 xbt_swag_remove(elem, &(elem->constraint->enabled_element_set));
1033 xbt_swag_insert_at_tail(elem, &(elem->constraint->disabled_element_set));
1035 xbt_swag_remove(elem, &(elem->constraint->active_element_set));
1037 lmm_decrease_concurrency(elem);
1041 var->staged_weight=0.0;
1043 lmm_check_concurrency(sys);
1046 /* /brief Find variables that can be enabled and enable them.
1048 * Assuming that the variable has already been removed from non-zero weights
1049 * Can we find a staged variable to add?
1050 * If yes, check that none of the constraints that this variable is involved in is at the limit of its concurrency
1051 * And then add it to enabled variables
1053 void lmm_on_disabled_var(lmm_system_t sys, lmm_constraint_t cnstr){
1055 lmm_element_t nextelem;
1058 if(cnstr->concurrency_limit<0)
1061 numelem=xbt_swag_size(&(cnstr->disabled_element_set));
1065 elem= (lmm_element_t) xbt_swag_getFirst(&(cnstr->disabled_element_set));
1067 //Cannot use xbt_swag_foreach, because lmm_enable_var will modify disabled_element_set.. within the loop
1068 while(numelem-- && elem ){
1070 nextelem = (lmm_element_t) xbt_swag_getNext(elem, cnstr->disabled_element_set.offset);
1072 if (elem->variable->staged_weight>0 ){
1073 //Found a staged variable
1074 //TODOLATER: Add random timing function to model reservation protocol fuzziness? Then how to make sure that
1075 //staged variables will eventually be called?
1076 if(lmm_can_enable_var(elem->variable)){
1077 lmm_enable_var(sys,elem->variable);
1081 xbt_assert(cnstr->concurrency_current<=cnstr->concurrency_limit,"Concurrency overflow!");
1082 if(cnstr->concurrency_current==cnstr->concurrency_limit)
1088 //We could get an assertion fail, because transiently there can be variables that are staged and could be activated.
1089 //And we need to go through all constraints of the disabled var before getting back a coherent state.
1090 //Anyway, caller functions all call lmm_check_concurrency() in the end.
1091 // lmm_check_concurrency(sys);
1094 /* \brief update the weight of a variable, and enable/disable it.
1095 * @return Returns whether a change was made
1097 void lmm_update_variable_weight(lmm_system_t sys, lmm_variable_t var, double weight)
1101 xbt_assert(weight>=0,"Variable weight should not be negative!");
1103 if (weight == var->weight)
1106 int enabling_var= (weight>0 && var->weight<=0);
1107 int disabling_var= (weight<=0 && var->weight>0);
1109 XBT_IN("(sys=%p, var=%p, weight=%f)", sys, var, weight);
1113 //Are we enabling this variable?
1115 var->staged_weight = weight;
1116 minslack=lmm_cnstrs_min_concurrency_slack(var);
1117 if(minslack<var->concurrency_share){
1118 XBT_DEBUG("Staging var (instead of enabling) because min concurrency slack %i, with weight %f and concurrency"
1119 " share %i", minslack, weight, var->concurrency_share);
1122 XBT_DEBUG("Enabling var with min concurrency slack %i", minslack);
1123 lmm_enable_var(sys,var);
1124 } else if (disabling_var){
1125 //Are we disabling this variable?
1126 lmm_disable_var(sys,var);
1131 lmm_check_concurrency(sys);
1137 double lmm_get_variable_weight(lmm_variable_t var)
1142 void lmm_update_constraint_bound(lmm_system_t sys, lmm_constraint_t cnst, double bound)
1145 lmm_update_modified_set(sys, cnst);
1146 cnst->bound = bound;
1149 int lmm_constraint_used(lmm_system_t sys, lmm_constraint_t cnst)
1151 return xbt_swag_belongs(cnst, &(sys->active_constraint_set));
1154 inline lmm_constraint_t lmm_get_first_active_constraint(lmm_system_t sys)
1156 return (lmm_constraint_t)xbt_swag_getFirst(&(sys->active_constraint_set));
1159 inline lmm_constraint_t lmm_get_next_active_constraint(lmm_system_t sys, lmm_constraint_t cnst)
1161 return (lmm_constraint_t)xbt_swag_getNext(cnst, (sys->active_constraint_set).offset);
1164 /** \brief Update the constraint set propagating recursively to
1165 * other constraints so the system should not be entirely computed.
1167 * \param sys the lmm_system_t
1168 * \param cnst the lmm_constraint_t affected by the change
1170 * A recursive algorithm to optimize the system recalculation selecting only constraints that have changed. Each
1171 * constraint change is propagated to the list of constraints for each variable.
1173 static void lmm_update_modified_set_rec(lmm_system_t sys, lmm_constraint_t cnst)
1177 //TODOLATER: Why lmm_modified_set has been changed in git version 2392B5157...? Looks equivalent logically and less obvious..
1178 xbt_swag_foreach(_elem, &cnst->enabled_element_set) {
1179 lmm_variable_t var = ((lmm_element_t)_elem)->variable;
1180 s_lmm_element_t *cnsts = var->cnsts;
1182 for (i = 0; var->visited != sys->visited_counter && i < var->cnsts_number ; i++) {
1183 if (cnsts[i].constraint != cnst && !xbt_swag_belongs(cnsts[i].constraint, &sys->modified_constraint_set)) {
1184 xbt_swag_insert(cnsts[i].constraint, &sys->modified_constraint_set);
1185 lmm_update_modified_set_rec(sys, cnsts[i].constraint);
1188 //var will be ignored in later visits as long as sys->visited_counter does not move
1189 var->visited = sys->visited_counter;
1193 static void lmm_update_modified_set(lmm_system_t sys, lmm_constraint_t cnst)
1195 /* nothing to do if selective update isn't active */
1196 if (sys->selective_update_active && !xbt_swag_belongs(cnst, &sys->modified_constraint_set)) {
1197 xbt_swag_insert(cnst, &sys->modified_constraint_set);
1198 lmm_update_modified_set_rec(sys, cnst);
1202 /** \brief Remove all constraints of the modified_constraint_set.
1204 * \param sys the lmm_system_t
1206 static void lmm_remove_all_modified_set(lmm_system_t sys)
1208 //We cleverly un-flag all variables just by incrementing sys->visited_counter
1209 //In effect, the var->visited value will no more be equal to sys->visited counter
1210 //To be clean, when visited counter has wrapped around, we force these var->visited values so that variables that
1211 //were in the modified a long (long long) time ago are not wrongly skipped here, which would lead to very nasty bugs
1212 //(i.e. not readibily reproducible, and requiring a lot of run time before happening).
1213 if (++sys->visited_counter == 1) {
1214 /* the counter wrapped around, reset each variable->visited */
1216 xbt_swag_foreach(_var, &sys->variable_set)
1217 ((lmm_variable_t)_var)->visited = 0;
1219 xbt_swag_reset(&sys->modified_constraint_set);
1223 * Returns total resource load
1225 * \param cnst the lmm_constraint_t associated to the resource
1227 * This is dead code, but we may use it later for debug/trace.
1229 double lmm_constraint_get_usage(lmm_constraint_t cnst) {
1231 xbt_swag_t elem_list = &(cnst->enabled_element_set);
1233 lmm_element_t elem = nullptr;
1235 xbt_swag_foreach(_elem, elem_list) {
1236 elem = (lmm_element_t)_elem;
1237 if ((elem->value > 0)) {
1238 if (cnst->sharing_policy)
1239 usage += elem->value * elem->variable->value;
1240 else if (usage < elem->value * elem->variable->value)
1241 usage = elem->value * elem->variable->value;
1247 void lmm_check_concurrency(lmm_system_t sys){
1252 lmm_constraint_t cnst;
1255 int i,belong_to_enabled,belong_to_disabled,belong_to_active;
1257 //These checks are very expensive, so do them only if we want to debug SURF LMM
1258 if (XBT_LOG_ISENABLED(surf_maxmin, xbt_log_priority_debug)) {
1259 xbt_swag_foreach(_cnst, &(sys->constraint_set)) {
1260 cnst = (lmm_constraint_t) _cnst;
1262 xbt_swag_foreach(_elem, &(cnst->enabled_element_set)) {
1263 elem = (lmm_element_t)_elem;
1264 xbt_assert(elem->variable->weight > 0);
1265 concurrency+=lmm_element_concurrency(elem);
1268 xbt_swag_foreach(_elem, &(cnst->disabled_element_set)) {
1269 elem = (lmm_element_t)_elem;
1270 //We should have staged variables only if concurrency is reached in some constraint
1271 xbt_assert(cnst->concurrency_limit<0 || elem->variable->staged_weight==0 ||
1272 lmm_cnstrs_min_concurrency_slack(elem->variable) < elem->variable->concurrency_share,
1273 "should not have staged variable!");
1276 xbt_assert(cnst->concurrency_limit<0 || cnst->concurrency_limit >= concurrency,"concurrency check failed!");
1277 xbt_assert(cnst->concurrency_current == concurrency, "concurrency_current is out-of-date!");
1280 //Check that for each variable, all corresponding elements are in the same state (i.e. same element sets)
1281 xbt_swag_foreach(_var, &(sys->variable_set)) {
1282 var= (lmm_variable_t) _var;
1284 if(!var->cnsts_number)
1287 elem = &var->cnsts[0];
1288 belong_to_enabled=xbt_swag_belongs(elem,&(elem->constraint->enabled_element_set));
1289 belong_to_disabled=xbt_swag_belongs(elem,&(elem->constraint->disabled_element_set));
1290 belong_to_active=xbt_swag_belongs(elem,&(elem->constraint->active_element_set));
1292 for (i = 1; i < var->cnsts_number; i++) {
1293 elem = &var->cnsts[i];
1294 xbt_assert(belong_to_enabled==xbt_swag_belongs(elem,&(elem->constraint->enabled_element_set)),
1295 "Variable inconsistency (1): enabled_element_set");
1296 xbt_assert(belong_to_disabled==xbt_swag_belongs(elem,&(elem->constraint->disabled_element_set)),
1297 "Variable inconsistency (2): disabled_element_set");
1298 xbt_assert(belong_to_active==xbt_swag_belongs(elem,&(elem->constraint->active_element_set)),
1299 "Variable inconsistency (3): active_element_set");