1 /* Copyright (c) 2013-2023. The SimGrid Team. All rights reserved. */
3 /* This program is free software; you can redistribute it and/or modify it
4 * under the terms of the license (GNU LGPL) which comes with this package. */
6 #include "src/surf/network_cm02.hpp"
7 #include "simgrid/kernel/routing/NetZoneImpl.hpp"
8 #include "simgrid/s4u/Engine.hpp"
9 #include "simgrid/s4u/Host.hpp"
10 #include "simgrid/sg_config.hpp"
11 #include "src/kernel/EngineImpl.hpp"
12 #include "src/kernel/resource/StandardLinkImpl.hpp"
13 #include "src/kernel/resource/WifiLinkImpl.hpp"
14 #include "src/kernel/resource/profile/Event.hpp"
15 #include "src/surf/surf_interface.hpp"
20 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(res_network);
25 static simgrid::config::Flag<std::string> cfg_network_solver("network/solver",
26 "Set linear equations solver used by network model",
27 "maxmin", &simgrid::kernel::lmm::System::validate_solver);
29 /******************************************************************************/
30 /* Network model based on optimizations discussed during Pedro Velho's thesis */
31 /******************************************************************************/
32 /* @techreport{VELHO:2011:HAL-00646896:1, */
33 /* url = {http://hal.inria.fr/hal-00646896/en/}, */
34 /* title = {{Flow-level network models: have we reached the limits?}}, */
35 /* author = {Velho, Pedro and Schnorr, Lucas and Casanova, Henri and Legrand, Arnaud}, */
36 /* type = {Rapport de recherche}, */
37 /* institution = {INRIA}, */
38 /* number = {RR-7821}, */
41 /* pdf = {http://hal.inria.fr/hal-00646896/PDF/rr-validity.pdf}, */
43 SIMGRID_REGISTER_NETWORK_MODEL(
45 "Realistic network analytic model (slow-start modeled by multiplying latency by 13.01, bandwidth by .97; "
46 "bottleneck sharing uses a payload of S=20537 for evaluating RTT). ",
48 auto net_model = std::make_shared<simgrid::kernel::resource::NetworkCm02Model>("Network_LegrandVelho");
49 auto* engine = simgrid::kernel::EngineImpl::get_instance();
50 engine->add_model(net_model);
51 engine->get_netzone_root()->set_network_model(net_model);
53 simgrid::config::set_default<std::string>("network/latency-factor", "13.01");
54 simgrid::config::set_default<std::string>("network/bandwidth-factor", "0.97");
55 simgrid::config::set_default<double>("network/weight-S", 20537);
58 /****************************************************************************/
59 /* The older TCP sharing model designed by Loris Marchal and Henri Casanova */
60 /****************************************************************************/
61 /* @TechReport{ rr-lip2002-40, */
62 /* author = {Henri Casanova and Loris Marchal}, */
63 /* institution = {LIP}, */
64 /* title = {A Network Model for Simulation of Grid Application}, */
65 /* number = {2002-40}, */
69 SIMGRID_REGISTER_NETWORK_MODEL(
71 "Legacy network analytic model (Very similar to LV08, but without corrective factors. The timings of "
72 "small messages are thus poorly modeled).",
74 simgrid::config::set_default<std::string>("network/latency-factor", "1.0");
75 simgrid::config::set_default<std::string>("network/bandwidth-factor", "1.0");
76 simgrid::config::set_default<double>("network/weight-S", 0.0);
78 auto net_model = std::make_shared<simgrid::kernel::resource::NetworkCm02Model>("Network_CM02");
79 auto* engine = simgrid::kernel::EngineImpl::get_instance();
80 engine->add_model(net_model);
81 engine->get_netzone_root()->set_network_model(net_model);
84 /********************************************************************/
85 /* Model based on LV08 and experimental results of MPI ping-pongs */
86 /********************************************************************/
87 /* @Inproceedings{smpi_ipdps, */
88 /* author={Pierre-Nicolas Clauss and Mark Stillwell and Stéphane Genaud and Frédéric Suter and Henri Casanova and
90 /* title={Single Node On-Line Simulation of {MPI} Applications with SMPI}, */
91 /* booktitle={25th IEEE International Parallel and Distributed Processing Symposium (IPDPS'11)}, */
92 /* address={Anchorage (Alaska) USA}, */
96 SIMGRID_REGISTER_NETWORK_MODEL(
98 "Realistic network model specifically tailored for HPC settings (accurate modeling of slow start with "
99 "correction factors on three intervals: < 1KiB, < 64 KiB, >= 64 KiB)",
101 auto net_model = std::make_shared<simgrid::kernel::resource::NetworkCm02Model>("Network_SMPI");
102 auto* engine = simgrid::kernel::EngineImpl::get_instance();
103 engine->add_model(net_model);
104 engine->get_netzone_root()->set_network_model(net_model);
106 simgrid::config::set_default<double>("network/weight-S", 8775);
107 simgrid::config::set_default<std::string>("network/bandwidth-factor",
108 "65472:0.940694;15424:0.697866;9376:0.58729;5776:1.08739;3484:0.77493;"
109 "1426:0.608902;732:0.341987;257:0.338112;0:0.812084");
110 simgrid::config::set_default<std::string>("network/latency-factor",
111 "65472:11.6436;15424:3.48845;9376:2.59299;5776:2.18796;3484:1.88101;"
112 "1426:1.61075;732:1.9503;257:1.95341;0:2.01467");
115 namespace simgrid::kernel::resource {
117 NetworkCm02Model::NetworkCm02Model(const std::string& name) : NetworkModel(name)
119 std::string optim = config::get_value<std::string>("network/optim");
120 bool select = config::get_value<bool>("network/maxmin-selective-update");
122 if (optim == "Lazy") {
123 set_update_algorithm(Model::UpdateAlgo::LAZY);
124 xbt_assert(select || config::is_default("network/maxmin-selective-update"),
125 "You cannot disable network selective update when using the lazy update mechanism");
129 set_maxmin_system(lmm::System::build(cfg_network_solver.get(), select));
131 loopback_.reset(create_link("__loopback__", {config::get_value<double>("network/loopback-bw")}));
132 loopback_->set_sharing_policy(s4u::Link::SharingPolicy::FATPIPE, {});
133 loopback_->set_latency(config::get_value<double>("network/loopback-lat"));
134 loopback_->get_iface()->seal();
137 StandardLinkImpl* NetworkCm02Model::create_link(const std::string& name, const std::vector<double>& bandwidths)
139 xbt_assert(bandwidths.size() == 1, "Non-WIFI links must use only 1 bandwidth.");
140 auto link = new NetworkCm02Link(name, bandwidths[0], get_maxmin_system());
141 link->set_model(this);
145 StandardLinkImpl* NetworkCm02Model::create_wifi_link(const std::string& name, const std::vector<double>& bandwidths)
147 auto link = new WifiLinkImpl(name, bandwidths, get_maxmin_system());
148 link->set_model(this);
152 void NetworkCm02Model::update_actions_state_lazy(double now, double /*delta*/)
154 while (not get_action_heap().empty() && double_equals(get_action_heap().top_date(), now, sg_surf_precision)) {
155 auto* action = static_cast<NetworkCm02Action*>(get_action_heap().pop());
156 XBT_DEBUG("Something happened to action %p", action);
158 // if I am wearing a latency hat
159 if (action->get_type() == ActionHeap::Type::latency) {
160 XBT_DEBUG("Latency paid for action %p. Activating", action);
161 get_maxmin_system()->update_variable_penalty(action->get_variable(), action->sharing_penalty_);
162 get_action_heap().remove(action);
163 action->set_last_update();
165 // if I am wearing a max_duration or normal hat
166 } else if (action->get_type() == ActionHeap::Type::max_duration || action->get_type() == ActionHeap::Type::normal) {
167 // no need to communicate anymore
168 // assume that flows that reached max_duration have remaining of 0
169 XBT_DEBUG("Action %p finished", action);
170 action->finish(Action::State::FINISHED);
171 get_action_heap().remove(action);
176 void NetworkCm02Model::update_actions_state_full(double /*now*/, double delta)
178 for (auto it = std::begin(*get_started_action_set()); it != std::end(*get_started_action_set());) {
179 auto& action = static_cast<NetworkCm02Action&>(*it);
180 ++it; // increment iterator here since the following calls to action.finish() may invalidate it
181 XBT_DEBUG("Something happened to action %p", &action);
182 if (action.latency_ > 0) {
183 if (action.latency_ > delta) {
184 double_update(&action.latency_, delta, sg_surf_precision);
186 action.latency_ = 0.0;
188 if (action.latency_ <= 0.0 && not action.is_suspended())
189 get_maxmin_system()->update_variable_penalty(action.get_variable(), action.sharing_penalty_);
192 if (not action.get_variable()->get_number_of_constraint()) {
193 /* There is actually no link used, hence an infinite bandwidth. This happens often when using models like
194 * vivaldi. In such case, just make sure that the action completes immediately.
196 action.update_remains(action.get_remains());
198 action.update_remains(action.get_rate() * delta);
200 if (action.get_max_duration() != NO_MAX_DURATION)
201 action.update_max_duration(delta);
203 if (((action.get_remains() <= 0) && (action.get_variable()->get_penalty() > 0)) ||
204 ((action.get_max_duration() != NO_MAX_DURATION) && (action.get_max_duration() <= 0))) {
205 action.finish(Action::State::FINISHED);
210 void NetworkCm02Model::comm_action_expand_constraints(const s4u::Host* src, const s4u::Host* dst,
211 const NetworkCm02Action* action,
212 const std::vector<StandardLinkImpl*>& route,
213 const std::vector<StandardLinkImpl*>& back_route) const
215 /* expand route links constraints for route and back_route */
216 const WifiLinkImpl* src_wifi_link = nullptr;
217 const WifiLinkImpl* dst_wifi_link = nullptr;
218 if (not route.empty() && route.front()->get_sharing_policy() == s4u::Link::SharingPolicy::WIFI) {
219 src_wifi_link = static_cast<WifiLinkImpl*>(route.front());
221 if (route.size() > 1 && route.back()->get_sharing_policy() == s4u::Link::SharingPolicy::WIFI) {
222 dst_wifi_link = static_cast<WifiLinkImpl*>(route.back());
225 /* WI-FI links needs special treatment, do it here */
226 if (src_wifi_link != nullptr) {
227 if (src_wifi_link->get_host_rate(src) > 0)
228 get_maxmin_system()->expand(src_wifi_link->get_constraint(), action->get_variable(),
229 1.0 / src_wifi_link->get_host_rate(src));
231 get_maxmin_system()->update_variable_penalty(action->get_variable(), 0);
235 if (dst_wifi_link != nullptr) {
236 if (dst_wifi_link->get_host_rate(dst) > 0)
237 get_maxmin_system()->expand(dst_wifi_link->get_constraint(), action->get_variable(),
238 1.0 / dst_wifi_link->get_host_rate(dst));
240 get_maxmin_system()->update_variable_penalty(action->get_variable(), 0);
244 for (auto const* link : route) {
245 if (link->get_sharing_policy() != s4u::Link::SharingPolicy::WIFI)
246 get_maxmin_system()->expand(link->get_constraint(), action->get_variable(), 1.0);
249 if (cfg_crosstraffic) {
250 XBT_DEBUG("Crosstraffic active: adding backward flow using 5%% of the available bandwidth");
251 if (dst_wifi_link != nullptr)
252 get_maxmin_system()->expand(dst_wifi_link->get_constraint(), action->get_variable(),
253 .05 / dst_wifi_link->get_host_rate(dst));
254 if (src_wifi_link != nullptr)
255 get_maxmin_system()->expand(src_wifi_link->get_constraint(), action->get_variable(),
256 .05 / src_wifi_link->get_host_rate(src));
258 for (auto const* link : back_route) {
259 if (link->get_sharing_policy() != s4u::Link::SharingPolicy::WIFI)
260 get_maxmin_system()->expand(link->get_constraint(), action->get_variable(), .05);
265 NetworkCm02Action* NetworkCm02Model::comm_action_create(s4u::Host* src, s4u::Host* dst, double size,
266 const std::vector<StandardLinkImpl*>& route, bool failed)
268 WifiLinkImpl* src_wifi_link = nullptr;
269 WifiLinkImpl* dst_wifi_link = nullptr;
270 /* many checks related to Wi-Fi links */
271 if (not route.empty() && route.front()->get_sharing_policy() == s4u::Link::SharingPolicy::WIFI) {
272 src_wifi_link = static_cast<WifiLinkImpl*>(route.front());
273 xbt_assert(src_wifi_link->get_host_rate(src) != -1,
274 "The route from %s to %s begins with the WIFI link %s, but the host %s does not seem attached to that "
275 "WIFI link. Did you call link->set_host_rate()?",
276 src->get_cname(), dst->get_cname(), src_wifi_link->get_cname(), src->get_cname());
278 if (route.size() > 1 && route.back()->get_sharing_policy() == s4u::Link::SharingPolicy::WIFI) {
279 dst_wifi_link = static_cast<WifiLinkImpl*>(route.back());
280 xbt_assert(dst_wifi_link->get_host_rate(dst) != -1,
281 "The route from %s to %s ends with the WIFI link %s, but the host %s does not seem attached to that "
282 "WIFI link. Did you call link->set_host_rate()?",
283 src->get_cname(), dst->get_cname(), dst_wifi_link->get_cname(), dst->get_cname());
285 if (route.size() > 2)
286 for (unsigned i = 1; i < route.size() - 1; i++)
287 xbt_assert(route[i]->get_sharing_policy() != s4u::Link::SharingPolicy::WIFI,
288 "Link '%s' is a WIFI link. It can only be at the beginning or the end of the route from '%s' to '%s', "
289 "not in between (it is at position %u out of %zu). "
290 "Did you declare an access_point in your WIFI zones?",
291 route[i]->get_cname(), src->get_cname(), dst->get_cname(), i + 1, route.size());
293 for (auto const* link : route) {
294 if (link->get_sharing_policy() == s4u::Link::SharingPolicy::WIFI) {
295 xbt_assert(link == src_wifi_link || link == dst_wifi_link,
296 "Wifi links can only occur at the beginning of the route (meaning that it's attached to the src) or "
297 "at its end (meaning that it's attached to the dst");
301 /* create action and do some initializations */
302 NetworkCm02Action* action;
303 if (src_wifi_link == nullptr && dst_wifi_link == nullptr)
304 action = new NetworkCm02Action(this, *src, *dst, size, failed);
306 action = new WifiLinkAction(this, *src, *dst, size, failed, src_wifi_link, dst_wifi_link);
308 if (is_update_lazy()) {
309 action->set_last_update();
315 bool NetworkCm02Model::comm_get_route_info(const s4u::Host* src, const s4u::Host* dst, double& latency,
316 std::vector<StandardLinkImpl*>& route,
317 std::vector<StandardLinkImpl*>& back_route,
318 std::unordered_set<kernel::routing::NetZoneImpl*>& netzones) const
320 kernel::routing::NetZoneImpl::get_global_route_with_netzones(src->get_netpoint(), dst->get_netpoint(), route,
323 xbt_assert(not route.empty() || latency > 0,
324 "You're trying to send data from %s to %s but there is no connecting path between these two hosts.",
325 src->get_cname(), dst->get_cname());
327 bool failed = std::any_of(route.begin(), route.end(), [](const StandardLinkImpl* link) { return not link->is_on(); });
329 if (not failed && cfg_crosstraffic) {
330 dst->route_to(src, back_route, nullptr);
331 failed = std::any_of(back_route.begin(), back_route.end(),
332 [](const StandardLinkImpl* link) { return not link->is_on(); });
337 void NetworkCm02Model::comm_action_set_bounds(const s4u::Host* src, const s4u::Host* dst, double size,
338 NetworkCm02Action* action, const std::vector<StandardLinkImpl*>& route,
339 const std::unordered_set<kernel::routing::NetZoneImpl*>& netzones,
342 std::vector<s4u::Link*> s4u_route;
343 std::unordered_set<s4u::NetZone*> s4u_netzones;
345 /* transform data to user structures if necessary */
346 if (has_network_factor_cb()) {
347 std::for_each(route.begin(), route.end(),
348 [&s4u_route](StandardLinkImpl* l) { s4u_route.push_back(l->get_iface()); });
349 std::for_each(netzones.begin(), netzones.end(),
350 [&s4u_netzones](kernel::routing::NetZoneImpl* n) { s4u_netzones.insert(n->get_iface()); });
353 double bw_factor = get_bandwidth_factor(size, src, dst, s4u_route, s4u_netzones);
354 xbt_assert(bw_factor != 0, "Invalid param for comm %s -> %s. Bandwidth factor cannot be 0", src->get_cname(),
356 action->set_rate_factor(bw_factor);
358 /* get mininum bandwidth among links in the route and multiply by correct factor
359 * ignore wi-fi links, they're not considered for bw_factors */
360 double bandwidth_bound = -1.0;
361 for (const auto* l : route) {
362 if (l->get_sharing_policy() == s4u::Link::SharingPolicy::WIFI)
364 if (bandwidth_bound == -1.0 || l->get_bandwidth() < bandwidth_bound)
365 bandwidth_bound = l->get_bandwidth();
368 /* increase rate given by user considering the factor, since the actual rate will be
370 rate = rate / bw_factor;
371 /* the bandwidth is determined by the minimum between flow and user's defined rate */
372 if (rate >= 0 && rate < bandwidth_bound)
373 bandwidth_bound = rate;
374 action->set_user_bound(bandwidth_bound);
376 action->lat_current_ = action->latency_;
377 action->latency_ *= get_latency_factor(size, src, dst, s4u_route, s4u_netzones);
380 void NetworkCm02Model::comm_action_set_variable(NetworkCm02Action* action, const std::vector<StandardLinkImpl*>& route,
381 const std::vector<StandardLinkImpl*>& back_route, bool streamed)
383 size_t constraints_per_variable = route.size();
384 constraints_per_variable += back_route.size();
386 // setting the number of variable for a communication action involved in a I/O streaming operation
387 // requires to reserve some extra space for the constraints related to the source disk (global and read
388 // bandwidth) and destination disk (global and write bandwidth). We thus add 4 constraints.
389 constraints_per_variable += 4;
392 if (action->latency_ > 0) {
393 action->set_variable(get_maxmin_system()->variable_new(action, 0.0, -1.0, constraints_per_variable));
394 if (is_update_lazy()) {
395 // add to the heap the event when the latency is paid
396 double date = action->latency_ + action->get_last_update();
398 ActionHeap::Type type = route.empty() ? ActionHeap::Type::normal : ActionHeap::Type::latency;
400 XBT_DEBUG("Added action (%p) one latency event at date %f", action, date);
401 get_action_heap().insert(action, date, type);
404 action->set_variable(get_maxmin_system()->variable_new(action, 1.0, -1.0, constraints_per_variable));
406 /* after setting the variable, update the bounds depending on user configuration */
407 if (action->get_user_bound() < 0) {
408 get_maxmin_system()->update_variable_bound(
409 action->get_variable(),
410 (action->lat_current_ > 0 && cfg_tcp_gamma > 0) ? cfg_tcp_gamma / (2.0 * action->lat_current_) : -1.0);
412 get_maxmin_system()->update_variable_bound(
413 action->get_variable(), (action->lat_current_ > 0 && cfg_tcp_gamma > 0)
414 ? std::min(action->get_user_bound(), cfg_tcp_gamma / (2.0 * action->lat_current_))
415 : action->get_user_bound());
419 Action* NetworkCm02Model::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate, bool streamed)
421 double latency = 0.0;
422 std::vector<StandardLinkImpl*> back_route;
423 std::vector<StandardLinkImpl*> route;
424 std::unordered_set<kernel::routing::NetZoneImpl*> netzones;
426 XBT_IN("(%s,%s,%g,%g)", src->get_cname(), dst->get_cname(), size, rate);
428 bool failed = comm_get_route_info(src, dst, latency, route, back_route, netzones);
430 NetworkCm02Action* action = comm_action_create(src, dst, size, route, failed);
431 action->sharing_penalty_ = latency;
432 action->latency_ = latency;
434 if (cfg_weight_S_parameter > 0) {
435 action->sharing_penalty_ = std::accumulate(route.begin(), route.end(), action->sharing_penalty_,
436 [](double total, StandardLinkImpl* const& link) {
437 return total + cfg_weight_S_parameter / link->get_bandwidth();
441 /* setting bandwidth and latency bounds considering route and configured bw/lat factors */
442 comm_action_set_bounds(src, dst, size, action, route, netzones, rate);
444 /* creating the maxmin variable associated to this action */
445 comm_action_set_variable(action, route, back_route, streamed);
447 /* expand maxmin system to consider this communication in bw constraint for each link in route and back_route */
448 comm_action_expand_constraints(src, dst, action, route, back_route);
457 NetworkCm02Link::NetworkCm02Link(const std::string& name, double bandwidth, kernel::lmm::System* system)
458 : StandardLinkImpl(name)
460 bandwidth_.scale = 1.0;
461 bandwidth_.peak = bandwidth;
462 this->set_constraint(system->constraint_new(this, bandwidth));
465 void NetworkCm02Link::apply_event(kernel::profile::Event* triggered, double value)
467 /* Find out which of my iterators was triggered, and react accordingly */
468 if (triggered == bandwidth_.event) {
469 set_bandwidth(value);
470 tmgr_trace_event_unref(&bandwidth_.event);
472 } else if (triggered == latency_.event) {
474 tmgr_trace_event_unref(&latency_.event);
476 } else if (triggered == get_state_event()) {
483 xbt_die("Unknown event!\n");
486 XBT_DEBUG("There was a resource state event, need to update actions related to the constraint (%p)",
490 void NetworkCm02Link::set_bandwidth(double value)
492 double old_peak = bandwidth_.peak;
493 bandwidth_.peak = value;
495 get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), (bandwidth_.peak * bandwidth_.scale));
497 StandardLinkImpl::on_bandwidth_change();
499 if (NetworkModel::cfg_weight_S_parameter > 0) {
500 double delta = NetworkModel::cfg_weight_S_parameter / (bandwidth_.peak * bandwidth_.scale) -
501 NetworkModel::cfg_weight_S_parameter / (old_peak * bandwidth_.scale);
503 const kernel::lmm::Element* elem = nullptr;
504 const kernel::lmm::Element* nextelem = nullptr;
506 while (const auto* var = get_constraint()->get_variable_safe(&elem, &nextelem, &numelem)) {
507 auto* action = static_cast<NetworkCm02Action*>(var->get_id());
508 action->sharing_penalty_ += delta;
509 if (not action->is_suspended())
510 get_model()->get_maxmin_system()->update_variable_penalty(action->get_variable(), action->sharing_penalty_);
515 void NetworkCm02Link::set_latency(double value)
517 latency_check(value);
519 double delta = value - latency_.peak;
520 const kernel::lmm::Element* elem = nullptr;
521 const kernel::lmm::Element* nextelem = nullptr;
524 latency_.scale = 1.0;
525 latency_.peak = value;
527 while (const auto* var = get_constraint()->get_variable_safe(&elem, &nextelem, &numelem)) {
528 auto* action = static_cast<NetworkCm02Action*>(var->get_id());
529 action->lat_current_ += delta;
530 action->sharing_penalty_ += delta;
531 if (action->get_user_bound() < 0 && NetworkModel::cfg_tcp_gamma > 0)
532 get_model()->get_maxmin_system()->update_variable_bound(action->get_variable(), NetworkModel::cfg_tcp_gamma /
533 (2.0 * action->lat_current_));
534 else if (NetworkModel::cfg_tcp_gamma > 0) {
535 get_model()->get_maxmin_system()->update_variable_bound(
536 action->get_variable(),
537 std::min(action->get_user_bound(), NetworkModel::cfg_tcp_gamma / (2.0 * action->lat_current_)));
539 if (NetworkModel::cfg_tcp_gamma == 0 ||
540 action->get_user_bound() < NetworkModel::cfg_tcp_gamma / (2.0 * action->lat_current_)) {
541 XBT_DEBUG("Flow is limited BYBANDWIDTH");
543 XBT_DEBUG("Flow is limited BYLATENCY, latency of flow is %f", action->lat_current_);
546 if (not action->is_suspended())
547 get_model()->get_maxmin_system()->update_variable_penalty(action->get_variable(), action->sharing_penalty_);
555 void NetworkCm02Action::update_remains_lazy(double now)
557 if (not is_running())
560 double delta = now - get_last_update();
562 if (get_remains_no_update() > 0) {
563 XBT_DEBUG("Updating action(%p): remains was %f, last_update was: %f", this, get_remains_no_update(),
565 update_remains(get_last_value() * delta);
567 XBT_DEBUG("Updating action(%p): remains is now %f", this, get_remains_no_update());
570 update_max_duration(delta);
572 if ((get_remains_no_update() <= 0 && (get_variable()->get_penalty() > 0)) ||
573 ((get_max_duration() != NO_MAX_DURATION) && (get_max_duration() <= 0))) {
574 finish(Action::State::FINISHED);
575 get_model()->get_action_heap().remove(this);
579 set_last_value(get_rate());
582 } // namespace simgrid::kernel::resource