Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Use sensible names for variables.
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Thu, 17 Dec 2020 11:00:15 +0000 (12:00 +0100)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Thu, 17 Dec 2020 11:02:23 +0000 (12:02 +0100)
examples/s4u/app-bittorrent/s4u-tracker.cpp

index ba7c3fd..ffe71de 100644 (file)
@@ -36,15 +36,15 @@ void Tracker::operator()()
     if (comm->test()) {
       // Retrieve the data sent by the peer.
       xbt_assert(received != nullptr);
-      auto* tq = static_cast<TrackerQuery*>(received);
+      auto* query = static_cast<TrackerQuery*>(received);
 
       // Add the peer to our peer list, if not already known.
-      if (known_peers.find(tq->getPeerId()) == known_peers.end()) {
-        known_peers.insert(tq->getPeerId());
+      if (known_peers.find(query->getPeerId()) == known_peers.end()) {
+        known_peers.insert(query->getPeerId());
       }
 
       // Sending back peers to the requesting peer
-      auto* ta = new TrackerAnswer(TRACKER_QUERY_INTERVAL);
+      auto* answer = new TrackerAnswer(TRACKER_QUERY_INTERVAL);
       std::set<int>::iterator next_peer;
       int nb_known_peers = static_cast<int>(known_peers.size());
       int max_tries      = std::min(MAXIMUM_PEERS, nb_known_peers);
@@ -53,13 +53,13 @@ void Tracker::operator()()
         do {
           next_peer = known_peers.begin();
           std::advance(next_peer, random.uniform_int(0, nb_known_peers - 1));
-        } while (ta->getPeers().find(*next_peer) != ta->getPeers().end());
-        ta->addPeer(*next_peer);
+        } while (answer->getPeers().find(*next_peer) != answer->getPeers().end());
+        answer->addPeer(*next_peer);
         tried++;
       }
-      tq->getReturnMailbox()->put_init(ta, TRACKER_COMM_SIZE)->detach();
+      query->getReturnMailbox()->put_init(answer, TRACKER_COMM_SIZE)->detach();
 
-      delete tq;
+      delete query;
       comm = nullptr;
     } else {
       simgrid::s4u::this_actor::sleep_for(1);