Sonar smells

diff --git a/include/simgrid/kernel/routing/NetZoneImpl.hpp b/include/simgrid/kernel/routing/NetZoneImpl.hpp
index 97563da..72a09c6 100644 (file)
--- a/include/simgrid/kernel/routing/NetZoneImpl.hpp
+++ b/include/simgrid/kernel/routing/NetZoneImpl.hpp
@@ -81,7 +81,7 @@ class XBT_PUBLIC NetZoneImpl : public xbt::PropertyHolder {
   // this hpp is exported to the users and so cannot include the other internal hpp.
   class LinkDeleter {
   public:
-    void operator()(resource::StandardLinkImpl* link);
+    void operator()(resource::StandardLinkImpl* link) const;
   };
   std::map<std::string, std::unique_ptr<resource::StandardLinkImpl, LinkDeleter>, std::less<>> links_;
   /* save split-duplex links separately, keep links_ with only LinkImpl* seen by the user

diff --git a/src/kernel/resource/StandardLinkImpl.cpp b/src/kernel/resource/StandardLinkImpl.cpp
index cf3dfbb..92e4291 100644 (file)
--- a/src/kernel/resource/StandardLinkImpl.cpp
+++ b/src/kernel/resource/StandardLinkImpl.cpp
@@ -27,7 +27,7 @@ StandardLinkImpl::StandardLinkImpl(const std::string& name) : LinkImpl(name), pi
   XBT_DEBUG("Create link '%s'", name.c_str());
 }
 
-void StandardLinkImpl::Deleter::operator()(resource::StandardLinkImpl* link)
+void StandardLinkImpl::Deleter::operator()(resource::StandardLinkImpl* link) const
 {
   link->destroy();
 }

diff --git a/src/kernel/resource/StandardLinkImpl.hpp b/src/kernel/resource/StandardLinkImpl.hpp
index 818df95..1b06a36 100644 (file)
--- a/src/kernel/resource/StandardLinkImpl.hpp
+++ b/src/kernel/resource/StandardLinkImpl.hpp
@@ -36,7 +36,7 @@ public:
   void destroy(); // Must be called instead of the destructor
   class Deleter {
   public:
-    void operator()(StandardLinkImpl* link);
+    void operator()(StandardLinkImpl* link) const;
   };
 
   void latency_check(double latency) const;

diff --git a/src/kernel/routing/NetZoneImpl.cpp b/src/kernel/routing/NetZoneImpl.cpp
index 917f96b..a63f8a4 100644 (file)
--- a/src/kernel/routing/NetZoneImpl.cpp
+++ b/src/kernel/routing/NetZoneImpl.cpp
@@ -71,7 +71,7 @@ xbt::signal<void(bool symmetrical, kernel::routing::NetPoint* src, kernel::routi
                  std::vector<kernel::resource::StandardLinkImpl*> const& link_list)>
     NetZoneImpl::on_route_creation;
 
-void NetZoneImpl::LinkDeleter::operator()(resource::StandardLinkImpl* link)
+void NetZoneImpl::LinkDeleter::operator()(resource::StandardLinkImpl* link) const
 {
   link->destroy();
 }
@@ -160,7 +160,7 @@ std::vector<s4u::Link*> NetZoneImpl::get_filtered_links(const std::function<bool
 
 std::vector<s4u::Link*> NetZoneImpl::get_all_links() const
 {
-  return get_filtered_links([](s4u::Link*) { return true; });
+  return get_filtered_links([](const s4u::Link*) { return true; });
 }
 
 size_t NetZoneImpl::get_link_count() const

diff --git a/src/s4u/s4u_Engine.cpp b/src/s4u/s4u_Engine.cpp
index 7b529b4..c5a656a 100644 (file)
--- a/src/s4u/s4u_Engine.cpp
+++ b/src/s4u/s4u_Engine.cpp
@@ -298,7 +298,7 @@ size_t Engine::get_link_count() const
 /** @brief Returns the list of all links found in the platform */
 std::vector<Link*> Engine::get_all_links() const
 {
-  return get_filtered_links([](Link*) { return true; });
+  return get_filtered_links([](const Link*) { return true; });
 }
 
 std::vector<Link*> Engine::get_filtered_links(const std::function<bool(Link*)>& filter) const