Reduce scope for variables used for dynamic_cast to subclass.

Use the init-statement to declare variables inside the if statement (sonar).

diff --git a/examples/cpp/dag-from-dax/s4u-dag-from-dax.cpp b/examples/cpp/dag-from-dax/s4u-dag-from-dax.cpp
index a1b8538..a6c2538 100644 (file)
--- a/examples/cpp/dag-from-dax/s4u-dag-from-dax.cpp
+++ b/examples/cpp/dag-from-dax/s4u-dag-from-dax.cpp
@@ -46,8 +46,7 @@ int main(int argc, char** argv)
   static_cast<sg4::Exec*>(dag.back().get())->set_host(hosts[0]);
 
   for (const auto& a : dag) {
-    auto* exec = dynamic_cast<sg4::Exec*>(a.get());
-    if (exec != nullptr && exec->get_name() != "end") {
+    if (auto* exec = dynamic_cast<sg4::Exec*>(a.get()); exec != nullptr && exec->get_name() != "end") {
       exec->set_host(hosts[cursor % count]);
       cursor++;
     }

diff --git a/examples/cpp/dag-from-dot/s4u-dag-from-dot.cpp b/examples/cpp/dag-from-dot/s4u-dag-from-dot.cpp
index ca994ac..ef2d22f 100644 (file)
--- a/examples/cpp/dag-from-dot/s4u-dag-from-dot.cpp
+++ b/examples/cpp/dag-from-dot/s4u-dag-from-dot.cpp
@@ -44,8 +44,7 @@ int main(int argc, char** argv)
   static_cast<sg4::Exec*>(dag.back().get())->set_host(hosts[0]);
 
   for (const auto& a : dag) {
-    auto* exec = dynamic_cast<sg4::Exec*>(a.get());
-    if (exec != nullptr && exec->get_name() != "end") {
+    if (auto* exec = dynamic_cast<sg4::Exec*>(a.get()); exec != nullptr && exec->get_name() != "end") {
       exec->set_host(hosts[cursor % count]);
       cursor++;
     }