Const ref for std::string parameter.

diff --git a/src/smpi/include/smpi_utils.hpp b/src/smpi/include/smpi_utils.hpp
index 8d7b73c..977b9ad 100644 (file)
--- a/src/smpi/include/smpi_utils.hpp
+++ b/src/smpi/include/smpi_utils.hpp
@@ -23,7 +23,7 @@ namespace smpi {
 namespace utils {
   XBT_PUBLIC std::vector<s_smpi_factor_t> parse_factor(const std::string& smpi_coef_string);
   XBT_PUBLIC void add_benched_time(double time);
-  XBT_PUBLIC void account_malloc_size(size_t size, std::string file, int line, void* ptr);
+  XBT_PUBLIC void account_malloc_size(size_t size, const std::string& file, int line, void* ptr);
   XBT_PUBLIC void account_shared_size(size_t size);
   XBT_PUBLIC void print_time_analysis(double time);
   XBT_PUBLIC void print_buffer_info();

diff --git a/src/smpi/internals/smpi_utils.cpp b/src/smpi/internals/smpi_utils.cpp
index 1843467..1c61fa0 100644 (file)
--- a/src/smpi/internals/smpi_utils.cpp
+++ b/src/smpi/internals/smpi_utils.cpp
@@ -112,13 +112,14 @@ void add_benched_time(double time){
   total_benched_time += time;
 }
 
-void account_malloc_size(size_t size, std::string file, int line, void* ptr){
+void account_malloc_size(size_t size, const std::string& file, int line, void* ptr)
+{
   if (smpi_cfg_display_alloc()) {
     alloc_metadata_t metadata;
     metadata.size = size;
     metadata.line = line;
     metadata.numcall = 1;
-    metadata.file = std::string(file);
+    metadata.file    = file;
     allocs.insert(std::make_pair(ptr, metadata));
 
     total_malloc_size += size;
@@ -126,8 +127,8 @@ void account_malloc_size(size_t size, std::string file, int line, void* ptr){
       max_malloc.size = size;
       max_malloc.line = line;
       max_malloc.numcall = 1;
-      max_malloc.file = std::string(file);
-    }else if(size == max_malloc.size && max_malloc.line == line && not max_malloc.file.compare(file)){
+      max_malloc.file    = file;
+    } else if (size == max_malloc.size && max_malloc.line == line && max_malloc.file == file) {
       max_malloc.numcall++;
     }
   }