Try to please the ultramodern clang running on FreeBSD by properly giving a copy...

We should stop using the copy operator, and use a nice and clean
clone() call instead. Mathieu's on it.

diff --git a/src/mc/api/strategy/BasicStrategy.hpp b/src/mc/api/strategy/BasicStrategy.hpp
index 9c1a482..dfdbd5d 100644 (file)
--- a/src/mc/api/strategy/BasicStrategy.hpp
+++ b/src/mc/api/strategy/BasicStrategy.hpp
@@ -11,7 +11,10 @@ namespace simgrid::mc {
 /** Basic MC guiding class which corresponds to no guide at all (random choice) */
 class BasicStrategy : public Strategy {
 public:
-  void operator=(const BasicStrategy&) { return; }
+  void operator=(const BasicStrategy&)
+  { /* nothing to copy over while cloning */
+    return;
+  }
 
   std::pair<aid_t, double> next_transition() const override
   {

diff --git a/src/mc/api/strategy/Strategy.hpp b/src/mc/api/strategy/Strategy.hpp
index dc0cb10..c1bf76b 100644 (file)
--- a/src/mc/api/strategy/Strategy.hpp
+++ b/src/mc/api/strategy/Strategy.hpp
@@ -18,6 +18,11 @@ protected:
 
 public:
   virtual ~Strategy()                                      = default;
+  void operator=(const Strategy&)
+  { /* nothing to copy over while cloning */
+    return;
+  }
+
   virtual std::pair<aid_t, double> next_transition() const = 0;
   virtual void execute_next(aid_t aid, RemoteApp& app)     = 0;
   virtual void consider_best()                             = 0;