Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Define and use SwappedContext::verify_previous_context().
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Thu, 16 Jan 2020 20:07:45 +0000 (21:07 +0100)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Thu, 16 Jan 2020 21:30:20 +0000 (22:30 +0100)
It's used by BoostContext to verify that, after a context switch, the
originating context as it is expected.

src/kernel/context/ContextBoost.cpp
src/kernel/context/ContextSwapped.hpp

index b6da4a1..759837a 100644 (file)
@@ -43,7 +43,7 @@ void BoostContext::wrapper(BoostContext::arg_type arg)
   BoostContext* context = reinterpret_cast<BoostContext*>(arg);
 #else
   BoostContext* context = static_cast<BoostContext**>(arg.data)[1];
-  ASAN_ONLY(xbt_assert(context->asan_ctx_ == static_cast<BoostContext**>(arg.data)[0]));
+  context->verify_previous_context(static_cast<BoostContext**>(arg.data)[0]);
   ASAN_FINISH_SWITCH(nullptr, &context->asan_ctx_->asan_stack_, &context->asan_ctx_->asan_stack_size_);
   static_cast<BoostContext**>(arg.data)[0]->fc_ = arg.fctx;
 #endif
@@ -72,7 +72,7 @@ void BoostContext::swap_into(SwappedContext* to_)
   ASAN_ONLY(to->asan_ctx_ = this);
   ASAN_START_SWITCH(this->asan_stop_ ? nullptr : &fake_stack, to->asan_stack_, to->asan_stack_size_);
   boost::context::detail::transfer_t arg = boost::context::detail::jump_fcontext(to->fc_, ctx);
-  ASAN_ONLY(xbt_assert(this->asan_ctx_ == static_cast<BoostContext**>(arg.data)[0]));
+  this->verify_previous_context(static_cast<BoostContext**>(arg.data)[0]);
   ASAN_FINISH_SWITCH(fake_stack, &this->asan_ctx_->asan_stack_, &this->asan_ctx_->asan_stack_size_);
   static_cast<BoostContext**>(arg.data)[0]->fc_ = arg.fctx;
 #endif
index c495b34..cabea51 100644 (file)
@@ -57,6 +57,10 @@ public:
   bool asan_stop_           = false;
 #endif
 
+protected:
+  // With ASan, after a context switch, check that the originating context is the expected one (see BoostContext)
+  void verify_previous_context(const SwappedContext* context) const;
+
 private:
   static thread_local SwappedContext* worker_context_;
 
@@ -68,6 +72,13 @@ private:
 #endif
 };
 
+inline void SwappedContext::verify_previous_context(XBT_ATTRIB_UNUSED const SwappedContext* context) const
+{
+#if HAVE_SANITIZER_ADDRESS_FIBER_SUPPORT
+  xbt_assert(this->asan_ctx_ == context);
+#endif
+}
+
 } // namespace context
 } // namespace kernel
 } // namespace simgrid