Martin Quinson [Tue, 23 May 2023 22:45:49 +0000 (00:45 +0200)]
Hide a bit an internal method (make it protected)
Martin Quinson [Tue, 23 May 2023 22:25:44 +0000 (00:25 +0200)]
easy cleanup
Martin Quinson [Tue, 23 May 2023 21:56:46 +0000 (23:56 +0200)]
Give the on_this_ variant to all VM signals
Martin Quinson [Tue, 23 May 2023 21:27:32 +0000 (23:27 +0200)]
Sort the signals on the plugin page
+ also fix some documentation errors
Martin Quinson [Tue, 23 May 2023 21:20:44 +0000 (23:20 +0200)]
Rename Resource::on_state_change to Resource::on_onoff for sake of clarity
Martin Quinson [Tue, 23 May 2023 20:39:09 +0000 (22:39 +0200)]
Use the right version for the deprecate macro
Martin Quinson [Tue, 23 May 2023 19:50:15 +0000 (21:50 +0200)]
Give the _this_ variants to the Link signals
Arnaud Giersch [Tue, 23 May 2023 15:33:45 +0000 (17:33 +0200)]
Ignore ASan warnings about odr-violation with Activity_T::on_completion.
These are false positives IIUC.
[ci-skip]
Martin Quinson [Tue, 23 May 2023 18:57:11 +0000 (20:57 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Tue, 23 May 2023 18:43:26 +0000 (20:43 +0200)]
Various cleanups in the Host signals
- Add a on_this_*_cb variant to the Host signals
- Rename Activity::on_{suspended,resumed} for symmetry with Actor signals
- Change kernel::activity::CpuAction::on_state_change to s4u::Host::on_exec_state_change
Arnaud Giersch [Tue, 23 May 2023 13:46:51 +0000 (15:46 +0200)]
Remove global variables in PageStore_test too (mimic Snapshot_test).
Arnaud Giersch [Tue, 23 May 2023 12:33:54 +0000 (14:33 +0200)]
Use C++17 features: std::scoped_lock and structured bindings.
Arnaud Giersch [Tue, 23 May 2023 12:26:38 +0000 (14:26 +0200)]
Use the "_t" and "_v" version of type traits.
Arnaud Giersch [Tue, 23 May 2023 10:05:47 +0000 (12:05 +0200)]
Compact namespaces.
Arnaud Giersch [Tue, 23 May 2023 09:45:42 +0000 (11:45 +0200)]
C++17 support is now required for public headers too.
Update ChangeLog, FindSimGrid.cmake, and sonar-project.properties.
Fred Suter [Tue, 23 May 2023 10:36:14 +0000 (06:36 -0400)]
add Io operations and an example
Fred Suter [Tue, 23 May 2023 08:17:57 +0000 (04:17 -0400)]
another try to please clang
Fred Suter [Tue, 23 May 2023 07:56:02 +0000 (03:56 -0400)]
try to solve the -Wundefined-var-template thing with clang
Fred Suter [Tue, 23 May 2023 07:55:06 +0000 (03:55 -0400)]
allow operation to execute more than one function at start and end
Fred Suter [Mon, 22 May 2023 19:21:41 +0000 (15:21 -0400)]
add missing override
Fred Suter [Mon, 22 May 2023 17:49:53 +0000 (13:49 -0400)]
have a on_completion per activity type to save users some dynamic_cast-based filtering
Martin Quinson [Mon, 22 May 2023 15:13:14 +0000 (17:13 +0200)]
Add instance signals for all Disk signals
Martin Quinson [Mon, 22 May 2023 15:02:54 +0000 (17:02 +0200)]
Add instance signals for all Actor signals
Martin Quinson [Sat, 20 May 2023 22:05:31 +0000 (00:05 +0200)]
no need to save all ns3 sink points
Martin Quinson [Sat, 20 May 2023 21:46:51 +0000 (23:46 +0200)]
Rename cfg 'ns3/TcpModel' to 'ns3/UdpModel'
Martin Quinson [Fri, 19 May 2023 14:35:57 +0000 (16:35 +0200)]
Test that setting ns3 TCP models actually work
Martin Quinson [Fri, 12 May 2023 12:46:17 +0000 (14:46 +0200)]
cosmetics in the ChangeLog
Fred Suter [Mon, 22 May 2023 12:33:42 +0000 (08:33 -0400)]
allow activities launched by maestro to be instrumented
Fred Suter [Wed, 17 May 2023 19:14:07 +0000 (15:14 -0400)]
throw on_send and on_receive signals when doing a host-to-host Comm
this is needed by instrumentation
Fred Suter [Tue, 16 May 2023 15:40:38 +0000 (11:40 -0400)]
allow to set tracing category in STARTING state
Arnaud Giersch [Wed, 17 May 2023 12:14:35 +0000 (14:14 +0200)]
Explicitly capture required scope variables (sonar).
Arnaud Giersch [Wed, 17 May 2023 12:01:57 +0000 (14:01 +0200)]
Get rid of global variables for snapshot tests.
Also fix some sonar issues.
Arnaud Giersch [Tue, 16 May 2023 12:44:01 +0000 (14:44 +0200)]
Reduce scope for variables.
Arnaud Giersch [Tue, 16 May 2023 09:29:39 +0000 (11:29 +0200)]
Don't shadow outer variables.
Arnaud Giersch [Mon, 15 May 2023 15:12:12 +0000 (17:12 +0200)]
Use plain pointers instead of references to pointer.
Arnaud Giersch [Mon, 15 May 2023 13:25:05 +0000 (15:25 +0200)]
Suprious brace (fix non-linux builds).
Arnaud Giersch [Mon, 15 May 2023 08:39:45 +0000 (10:39 +0200)]
Define master_socket_name only once, and embed it with the request to fork.
Arnaud Giersch [Fri, 12 May 2023 09:19:55 +0000 (11:19 +0200)]
Try harder not to fail with stale sockets after several runs.
* on linux, prefer abstract unix sockets that are automatically removed
* otherwise, remove possible stale socket before bind
Arnaud Giersch [Fri, 12 May 2023 11:15:06 +0000 (13:15 +0200)]
The default destructor should be fine.
Arnaud Giersch [Fri, 12 May 2023 07:45:46 +0000 (09:45 +0200)]
Disable move constructor which cannot be 'noexecept' (sonar).
Arnaud Giersch [Fri, 12 May 2023 07:30:55 +0000 (09:30 +0200)]
Cosmetics.
Fred Suter [Thu, 11 May 2023 14:29:20 +0000 (10:29 -0400)]
add two more utility functions to the Operation plugin
Martin Quinson [Wed, 10 May 2023 21:35:25 +0000 (23:35 +0200)]
Fix make distcheck
Martin Quinson [Wed, 10 May 2023 21:27:34 +0000 (23:27 +0200)]
MC: Kill the now useless code State::get_recipe
Martin Quinson [Wed, 10 May 2023 21:22:28 +0000 (23:22 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Wed, 10 May 2023 21:21:10 +0000 (23:21 +0200)]
DFS MC: Restore from system states even if we have to run some transitions out of it
This makes the model-check/checkpoint a bit more efficient by
increasing the amount of cases where we can reuse taken checkpoints.
It is still awfully slow because checkpoints are. The next step is to
implement model-check/checkpoint with forks.
Martin Quinson [Wed, 10 May 2023 11:08:09 +0000 (11:08 +0000)]
Merge branch 'dag-lab' into 'master'
Add dag scheduling lab to docs
See merge request simgrid/simgrid!150
Martin Quinson [Wed, 10 May 2023 11:07:36 +0000 (11:07 +0000)]
Merge branch 'changelog-operation-plugin' into 'master'
Add plugins operation and battery to changelog
See merge request simgrid/simgrid!149
Arnaud Giersch [Tue, 9 May 2023 14:46:08 +0000 (16:46 +0200)]
Use forwarding references with std::forward (sonar).
(hope I got it right this time)
Arnaud Giersch [Tue, 9 May 2023 14:27:35 +0000 (16:27 +0200)]
Use a std::vector as an underlying container for backtrack_points, so that maximal_subsets_iterator can have a noexcept move constructor by default.
Arnaud Giersch [Tue, 9 May 2023 13:57:50 +0000 (15:57 +0200)]
Use a static variable for empty_set, and allow default noexcept move constructor.
Adrien Gougeon [Tue, 9 May 2023 12:45:25 +0000 (14:45 +0200)]
add dag scheduling lab
Arnaud Giersch [Mon, 8 May 2023 19:27:14 +0000 (21:27 +0200)]
Plug memory leak.
Arnaud Giersch [Sat, 6 May 2023 11:48:33 +0000 (13:48 +0200)]
Use pointer-to-const for parameter (sonar).
Arnaud Giersch [Fri, 5 May 2023 08:38:39 +0000 (10:38 +0200)]
Fix sonar bug: attribute access on a value that can be 'None'.
Arnaud Giersch [Thu, 4 May 2023 13:13:45 +0000 (15:13 +0200)]
Misc Sonar issues.
* declare functions "const"
* use pointer-to-const or reference-to-const
* use structured bindings
* extract assignment from expression
* mark constructors "explicit"
* pass large object parameters by reference-to-const
* use default implementation constructor
* explicitly capture required variables in lambdas
Fred Suter [Fri, 5 May 2023 01:20:01 +0000 (21:20 -0400)]
mess up with operations
+ chainable setters
+ getters
+ boost instrusive pointers
Martin Quinson [Thu, 4 May 2023 14:14:54 +0000 (16:14 +0200)]
Rename Link::get_usage() to Link::get_load() for consistency with Host::
Adrien Gougeon [Thu, 4 May 2023 09:22:11 +0000 (11:22 +0200)]
add plugins operation and battery
Fred Suter [Wed, 3 May 2023 14:39:56 +0000 (10:39 -0400)]
further simplify this example
Martin Quinson [Fri, 28 Apr 2023 00:01:20 +0000 (02:01 +0200)]
One use less of get_recipe() that will soon die
Martin Quinson [Thu, 27 Apr 2023 23:25:04 +0000 (01:25 +0200)]
Factorize more code between DFSExplo and LivenessExplo, and UDPOR
Arnaud Giersch [Tue, 2 May 2023 14:32:11 +0000 (16:32 +0200)]
Kill useless empty function.
Arnaud Giersch [Tue, 2 May 2023 14:22:02 +0000 (16:22 +0200)]
Missing "override".
Arnaud Giersch [Tue, 2 May 2023 14:14:43 +0000 (16:14 +0200)]
Simplify expression.
Arnaud Giersch [Tue, 2 May 2023 14:12:18 +0000 (16:12 +0200)]
Fix use-after-free observed with the s4u-operation examples.
Arnaud Giersch [Tue, 2 May 2023 14:24:29 +0000 (16:24 +0200)]
Cosmetics (sonar).
Arnaud Giersch [Tue, 11 Apr 2023 09:13:59 +0000 (11:13 +0200)]
Define each identifier in a dedicated statement (sonar).
Arnaud Giersch [Sat, 29 Apr 2023 08:03:02 +0000 (10:03 +0200)]
Revert "Run mc-*-liveness tests serial, and hope to pass on CI."
This reverts commit
881507dc9fbeba0c63112dd0058d9c591b67419e.
In fact, it was just the CI infrastructure that was unusually slow these days.
Arnaud Giersch [Tue, 18 Apr 2023 09:39:48 +0000 (11:39 +0200)]
Whitespace cleanup (codefactor.io).
Martin Quinson [Thu, 27 Apr 2023 13:41:03 +0000 (15:41 +0200)]
Lazily compute the recipe of a state, on need only
This will be useful when leveraging intermediate states during
backtracks. In that case, we need to compute partial recipes, up to
the advanced restaure point.
Martin Quinson [Thu, 27 Apr 2023 12:09:03 +0000 (14:09 +0200)]
More automatic memory mgmt in MC
Martin Quinson [Thu, 27 Apr 2023 11:48:19 +0000 (13:48 +0200)]
MC: give each state an incoming transition too
Using the parent's outgoing transition is not reliable anymore now
that we don't always explore the tree in order, but rather following
the exploration strategies.
Martin Quinson [Tue, 18 Apr 2023 07:01:51 +0000 (09:01 +0200)]
Fix comment [no-ci]
Arnaud Giersch [Thu, 27 Apr 2023 12:57:19 +0000 (14:57 +0200)]
Run mc-*-liveness tests serial, and hope to pass on CI.
Arnaud Giersch [Thu, 27 Apr 2023 09:28:08 +0000 (11:28 +0200)]
Fix comment.
Arnaud Giersch [Thu, 27 Apr 2023 09:27:02 +0000 (11:27 +0200)]
There is no need to declare the default constructors here.
Arnaud Giersch [Thu, 27 Apr 2023 09:26:20 +0000 (11:26 +0200)]
Fix build error: exception specification of explicitly
defaulted move constructor does not match the calculated one.
Martin Quinson [Wed, 26 Apr 2023 12:45:40 +0000 (12:45 +0000)]
Merge branch 'operation-plugin' into 'master'
Operation plugin
See merge request simgrid/simgrid!145
Martin Quinson [Tue, 18 Apr 2023 07:08:17 +0000 (07:08 +0000)]
Merge branch 'udpor-phase7' into 'master'
Phase 7 of UDPOR Integration: Add specialized `ex(C)` computation for `Comm*` transitions
See merge request simgrid/simgrid!144
Martin Quinson [Mon, 17 Apr 2023 08:01:01 +0000 (10:01 +0200)]
sonar fixes
- Undefined return value (that would happen on a platform without any host)
- Local variable shadowing
- Automatic memory management
- const, explicit, etc.
Martin Quinson [Sun, 16 Apr 2023 16:45:59 +0000 (18:45 +0200)]
Let resource profiles finish their initialization by themselves and kill presolve
Martin Quinson [Sun, 16 Apr 2023 16:31:13 +0000 (18:31 +0200)]
No need to presolve the models to finish their initialization nowadays
I think that this was a leftover of the good old C times.
Martin Quinson [Sun, 16 Apr 2023 10:23:18 +0000 (12:23 +0200)]
Only fire on_platform_created after creating the platform, not after loading the deployment
Martin Quinson [Sun, 16 Apr 2023 09:03:31 +0000 (11:03 +0200)]
Add a target to recompile all ns3 tests (and only them)
Adrien Gougeon [Sun, 16 Apr 2023 08:41:16 +0000 (10:41 +0200)]
rename create to init. add init with name only. add setters
Martin Quinson [Sat, 15 Apr 2023 22:38:08 +0000 (00:38 +0200)]
Make sure that we never have a 0 transition at the end of the stack
Martin Quinson [Sat, 15 Apr 2023 21:50:48 +0000 (23:50 +0200)]
Also send the disabled transitions over: UDPOR needs it
Martin Quinson [Sat, 15 Apr 2023 21:40:11 +0000 (23:40 +0200)]
More informative message on system error
Martin Quinson [Fri, 14 Apr 2023 12:21:47 +0000 (14:21 +0200)]
More defensive programing style
Adrien Gougeon [Fri, 14 Apr 2023 10:37:41 +0000 (12:37 +0200)]
add missing '&' causing temporary value to be modified
Adrien Gougeon [Fri, 14 Apr 2023 09:24:00 +0000 (11:24 +0200)]
rename on_start/on_end functions call to on_this_start/on_this_end. add on_start_cb and on_end_cb
Martin Quinson [Thu, 13 Apr 2023 21:51:41 +0000 (23:51 +0200)]
Trust the config system to check that only valid values are used
Arnaud Giersch [Wed, 12 Apr 2023 20:02:34 +0000 (22:02 +0200)]
Disable coverage on circleci.
It seems that it is not used and it slows down the tests.
[ci-skip]
Martin Quinson [Wed, 12 Apr 2023 20:46:30 +0000 (22:46 +0200)]
Make this example valgrind-clean
Martin Quinson [Wed, 12 Apr 2023 19:37:05 +0000 (21:37 +0200)]
Further cosmetics in that example, adding a helper function to s4u on the way
Fred Suter [Wed, 12 Apr 2023 18:19:28 +0000 (14:19 -0400)]
simplify the example now that host can be set to serial
Martin Quinson [Wed, 12 Apr 2023 15:58:18 +0000 (17:58 +0200)]
Use host->set_concurrency_limit(1) in an example where it makes sense
Martin Quinson [Wed, 12 Apr 2023 15:49:30 +0000 (17:49 +0200)]
Document a bit the MC changes
Martin Quinson [Wed, 12 Apr 2023 15:43:10 +0000 (17:43 +0200)]
Allow to set a concurrency limit on disks and hosts