Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Kill useless empty function.
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Tue, 2 May 2023 14:32:11 +0000 (16:32 +0200)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Tue, 2 May 2023 14:39:20 +0000 (16:39 +0200)
include/simgrid/plugins/operation.hpp
src/plugins/operation.cpp

index acd7ddd..0f2f0e6 100644 (file)
@@ -44,8 +44,8 @@ protected:
   int count_        = 0;
   bool working_     = false;
   simgrid::s4u::ActivityPtr current_activity_;
-  std::function<void(Operation*)> end_func_   = [](Operation*) {};
-  std::function<void(Operation*)> start_func_ = [](Operation*) {};
+  std::function<void(Operation*)> end_func_;
+  std::function<void(Operation*)> start_func_;
   Operation(const std::string& name);
   virtual ~Operation()   = default;
   virtual void execute() = 0;
index f9f8f1c..0629065 100644 (file)
@@ -105,7 +105,8 @@ void Operation::complete()
     working_ = false;
     count_++;
   });
-  end_func_(this);
+  if (end_func_)
+    end_func_(this);
   Operation::on_end(this);
   for (auto const& op : successors_)
     op->receive(this);
@@ -234,7 +235,8 @@ ExecOpPtr ExecOp::init(const std::string& name, double flops, simgrid::s4u::Host
  */
 void ExecOp::execute()
 {
-  start_func_(this);
+  if (start_func_)
+    start_func_(this);
   Operation::on_start(this);
   simgrid::kernel::actor::simcall_answered([this] {
     working_      = true;
@@ -301,7 +303,8 @@ CommOpPtr CommOp::init(const std::string& name, double bytes, simgrid::s4u::Host
  */
 void CommOp::execute()
 {
-  start_func_(this);
+  if (start_func_)
+    start_func_(this);
   Operation::on_start(this);
   simgrid::kernel::actor::simcall_answered([this] {
     working_      = true;